Repository navigation
Show resolved Bifrost revision in benchmark summaries - #201
Merged
Merged
Conversation
Scheduled runs against moving master can repeat the same public snapshot while private repairs are still unpublished. Include the resolved engine revision in the human-readable summary so the tested source is visible alongside the outcome. Prefer bifrostResolvedCommit and retain legacy Bifrost report support. Preserve machine-readable count and failing-case output. Validation: baseline Rust suites (273 tests), all 59 corpus documents, 44 Python tests, formatting, and seven focused summary tests.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Scheduled benchmark summaries identify Bifrost only as
master, so repeated failures against an unchanged public snapshot are easy to mistake for failures of newer private repairs. Show the exact resolved Bifrost revision beside the benchmark totals.Key Changes:
bifrostResolvedCommit, with a legacy Bifrost runner fallback; omit unavailable values.Touch Points:
scripts/render-benchmark-summary.shtests/benchmark_summary.rsValidation: baseline Rust suites (273 tests), all 59 benchmark documents, 44 Python tests, seven focused summary tests, Bash syntax, affected-file rustfmt, and diff checks passed. Full
cargo fmt --checkreports existing formatting differences in unchangedsrc/promotion.rs, reproduced from exact base3a6bf873. The original run37271122801 report now visibly names engine948f6700d2e668ee830aa42abf7ed4151d5bf560.This is provenance visibility only. Analyzer repairs and public benchmark qualification remain separate work.