Repository navigation
Fix conditional linkage overload guards for 0.24.3 - #6
Merged
Merged
Conversation
Register the qualified constructor rule in namespace declaration-list items and retain the original file-scope regression. Add nested namespace and ordinary expression controls, exercise both supported Rust runtimes, and prepare 0.24.2 metadata. All 213 corpus cases and 26 highlight assertions pass. Default/all-feature Rust tests and doctests pass on 0.25.10 and 0.26.13; Clippy, Node binding rebuild/test, package verification and repeat ABI15 generation pass. Bifrost downstream qualification is required before publication.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Split language-linkage headers can close
extern "C"and declare C++ overloads in the same conditional. The old grammar inserted a missing#endif, moving those overloads outside their guard and causing C callers to select them. This change retains the conditional ancestry and prepares grammar 0.24.3.Key Changes:
Touch Points:
grammar.js,src/grammar.json,src/parser.cbindings/rust/lib.rs,test/corpus/c/conditional-linkage-overloads.txtREADME.mdValidation: 215 corpus cases and 26 highlight assertions; 7 Rust tests plus doctest on Tree-sitter 0.26.13 and minimum 0.25.10, default and all features; Node binding test; ESLint; Rust formatting; whitespace; verified Cargo package. Latest upstream
c009222808634c1014f82438d4883753516a2c24is already incorporated. Bifrost integration reproduces the incorrect C-to-C++ lookup with published 0.24.2; integration with this release is being verified separately.