GAUD-9091: Fixing Keyboard Navigation In Calendar For RTL Langs

[EdwinACL831]

Jira

GAUD-9091

Solution

• Refactors logic to comply with the AXE regulations for calendar navigation. Independently from the language (RTL or LTR) when pressing HOME key should go to the starting day of the week. On the other hand when pressing END should go to the last day of the week.

[github-actions]

Thanks for the PR! 🎉

We've deployed an automatic preview for this PR - you can see your changes here:

URL	https://live.d2l.dev/prs/BrightspaceUI/core/pr-7048/

Note

The build needs to finish before your changes are deployed.
Changes to the PR will automatically update the instance.

[dbatiste]

I agree that Home key should move to the first day of the week (right-most day when using Arabic). And for the End key, it should move to the last day of the week (left-most day when using Arabic).

It is however weird for laptop users, because Fn+left arrow is Home, and Fn+right arrowis End, so when using Arabic, the directional movement does not match the keys they are pressing. Normally it would, for example when using Cmd+left arrow and Cmd+right arrow to select a string within an input, like "العربية (المملكة العربية السعودية)".

[EdwinACL831]

I agree that Home key should move to the first day of the week (right-most day when using Arabic). And for the End key, it should move to the last day of the week (left-most day when using Arabic).

It is however weird for laptop users, because Fn+left arrow is Home, and Fn+right arrowis End, so when using Arabic, the directional movement does not match the keys they are pressing. Normally it would, for example when using Cmd+left arrow and Cmd+right arrow to select a string within an input, like "العربية (المملكة العربية السعودية)".

I get your point and probably it will, I can test that on my laptop. And I also see that mine has an actual home button and end button (basically F11 and F12 are by default my Home and End buttons respectively). I can test how that works and fells but yeah I think this is scoped only to the calendar component according to WCAG, so maybe RTL users don't get mad very often.

[dbatiste]

I think this is what we want... that mapping just seems weird for laptop keyboards, but I think it is more of a hardware/OS thing. In the end, we were responding to the Home (36) and End (35) key codes.

[EdwinACL831]

I actually ran these 2 test with the previous implementation and they did fail. then rerun them after my changes and all was 🟢