fix: Refocus only on internal components#7044
Open
GZolla wants to merge 2 commits into
Open
Conversation
Contributor
|
Thanks for the PR! 🎉 We've deployed an automatic preview for this PR - you can see your changes here:
Note The build needs to finish before your changes are deployed. |
EdwinACL831
reviewed
Jun 4, 2026
| async _handleResize() { | ||
| const refocus = getComposedActiveElement(); | ||
| let refocus = getComposedActiveElement(); | ||
| if (!isComposedAncestor(this, refocus)) refocus = null; |
Contributor
There was a problem hiding this comment.
Is it possible to add automated tests to make sure if this is changed in the future is because it was intended and try to avoid any regressions ? I would request the same for the change below is that makes sense
dbatiste
reviewed
Jun 5, 2026
Contributor
dbatiste
left a comment
dbatiste
left a comment
There was a problem hiding this comment.
Test would be worthwhile. Otherwise looks good.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
GAUD-9997
The resize logic was refocusing on the active element since the calculations were setting
visibility: hiddenand causing focus to be lost. However, it was refocusing on ANY element in the DOM, causing components like the html editor to loose their current state(e.g. editing).This PR simply adds guards to check that the focus element is actually part of the tag-list