Repository navigation
Retain PDF export diagnostics and allow slow browser startup in E2E - #14
Merged
Merged
Conversation
|
Warning Review limit reachedYou've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. Next included review available in 31 minutes. View limit details
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The post-merge release gate timed out after 30 seconds while a correctly submitted PDF export was still pending. Its trace showed no error, and cleanup discarded the exporter's logs, leaving slow Chromium startup indistinguishable from a hung subprocess.
Allow the PDF file assertion 60 seconds for its two Chromium processes while retaining the 30-second HTML deadline, existing PDF-content assertions, 90-second test limit, and zero retries. Failed tests now retain isolated VS Code/extension logs and bounded process output after shutdown and before sandbox cleanup. Product code and packaged files are unchanged.
Validation: current and minimum VS Code PDF journeys pass; strict TypeScript and lint pass; independent review found no blockers. An intentional failure after a real successful PDF export retained 22 log files, process output, and the exporter's navigation/render/write/cleanup diagnostics, with the sandbox removed. Full CI must pass before merge; then restart the 0.5.0 release workflow on the updated main revision.