Improve runner auth error handling - #44
Conversation
Tighten and clarify runner authentication and error messages. Parse the Authorization header robustly (bearer_credential) and distinguish missing_token, empty_token, invalid_token and bootstrap_expired categories; add unit tests. Fail fast on set-but-blank RUNNER_TOKEN (token_from_env) so runners exit with actionable guidance instead of looping on unrecoverable 401s. Provide per-category remediation text in the runner WS client (auth_failure_help). Update docs (docs/deploy-runner.md and CLAUDE.md) to explain hosted-runner behavior and 401 reasons.
✅ Deploy Preview for overup-app ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
|
Warning Review limit reached
Next review available in: 29 minutes Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available. How can I continue?After more reviews become available, a review can be triggered using the To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews. How do review limits work?CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability. For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window. Please refer docs for additional details. Review details⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Free Run ID: 📒 Files selected for processing (5)
Note 🎁 Summarized by CodeRabbit FreeYour organization is on the Free plan. CodeRabbit will generate a high-level summary and a walkthrough for each pull request. For a comprehensive line-by-line review, please upgrade your subscription to CodeRabbit Pro by visiting https://app.coderabbit.ai/login. Comment |
![amazon-q-developer[bot]](https://avatars.githubusercontent.com/in/1220912?s=60&v=4){kind=small}
There was a problem hiding this comment.
This PR successfully improves runner authentication error handling with robust bearer credential parsing and clear per-category remediation guidance. The implementation correctly handles HTTP protocol details (RFC 9110 compliance for case-insensitive scheme matching and OWS stripping), adds fail-fast validation for blank tokens at runner boot, and provides comprehensive test coverage. The changes are security-conscious, well-documented, and follow established patterns in the codebase. All tests verify the correct behavior for edge cases including the outage regression scenario. Ready to merge.
You can now have the agent implement changes and create commits directly on your pull request's source branch. Simply comment with /q followed by your request in natural language to ask the agent to make changes.
1 participant
Tighten and clarify runner authentication and error messages. Parse the Authorization header robustly (bearer_credential) and distinguish missing_token, empty_token, invalid_token and bootstrap_expired categories; add unit tests. Fail fast on set-but-blank RUNNER_TOKEN (token_from_env) so runners exit with actionable guidance instead of looping on unrecoverable 401s. Provide per-category remediation text in the runner WS client (auth_failure_help). Update docs (docs/deploy-runner.md and CLAUDE.md) to explain hosted-runner behavior and 401 reasons.