Add detected requirements for secrets, vars, and environments - #31
Conversation
Implement sync-time workflow reference discovery and dispatch-time missing-configuration detection. Workflows now record which secrets, variables, and environments they reference via YAML metadata. Two new read endpoints compute "referenced but not configured" sets at query time, and UI cards offer one-click create flows to satisfy them. Names only—never values. Adds database queries, handlers, enhanced workflow parsing, frontend components, and types for the full feature flow including preset dialogs and bound-workflow listings.
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
✅ Deploy Preview for overup-app ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Free Run ID: 📒 Files selected for processing (21)
📝 WalkthroughWalkthroughWorkflow synchronization now records normalized secret, variable, and environment references. Authorized backend endpoints expose missing requirements and environment bindings, while secrets and environments pages offer seeded creation flows. The artifact summary strip is reduced to four KPI cells. ChangesDetected workflow requirements
Artifact summary layout
Estimated code review effort: 4 (Complex) | ~45 minutes Sequence Diagram(s)sequenceDiagram
participant WorkflowSync
participant WorkflowParser
participant WorkflowsMetadata
participant RequirementsAPI
participant RequirementsPage
WorkflowSync->>WorkflowParser: parse workflow YAML
WorkflowParser->>WorkflowsMetadata: store normalized references
RequirementsPage->>RequirementsAPI: request workspace requirements
RequirementsAPI->>WorkflowsMetadata: query stored references
WorkflowsMetadata-->>RequirementsAPI: missing requirements and bindings
RequirementsAPI-->>RequirementsPage: filtered requirement names and references
Note 🎁 Summarized by CodeRabbit FreeYour organization is on the Free plan. CodeRabbit will generate a high-level summary and a walkthrough for each pull request. For a comprehensive line-by-line review, please upgrade your subscription to CodeRabbit Pro by visiting https://app.coderabbit.ai/login. Comment |
![amazon-q-developer[bot]](https://avatars.githubusercontent.com/in/1220912?s=60&v=4){kind=small}
There was a problem hiding this comment.
This PR successfully implements workflow requirement detection for secrets, variables, and environments. The implementation demonstrates strong engineering practices with comprehensive validation, proper security measures, and good test coverage.
Key Strengths:
- Robust workflow YAML parsing with security protections (node budget limits, depth caps)
- SQL injection prevention through parameterized queries
- Comprehensive input validation throughout
- Proper authorization checks on all endpoints
- Extensive test coverage for parsing logic
- Secure secret handling with zeroizing buffers
The code is ready for merge.
You can now have the agent implement changes and create commits directly on your pull request's source branch. Simply comment with /q followed by your request in natural language to ask the agent to make changes.
1 participant
Implement sync-time workflow reference discovery and dispatch-time missing-configuration detection. Workflows now record which secrets, variables, and environments they reference via YAML metadata. Two new read endpoints compute "referenced but not configured" sets at query time, and UI cards offer one-click create flows to satisfy them. Names only—never values. Adds database queries, handlers, enhanced workflow parsing, frontend components, and types for the full feature flow including preset dialogs and bound-workflow listings.
Summary by CodeRabbit
New Features
Improvements