Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix SPI_PORT selection for ESP32-C3 (and other non-classic targets) on Arduino 2.x
The existing
#if ESP_ARDUINO_VERSION_MAJOR < 3guard setsSPI_PORTtoSPI2_HOST(value 1) on Arduino 2.x. However, per the ESP-IDF enumeration,SPI2_HOST = 1maps to the SPI1 hardware bus, which is reserved for internal flash on ESP32-C3 (and C5, C6, H2, S2, S3). The correct port for these targets is value2(SPI3_HOST, actually SPI2 hardware) — which is what the Arduino 3.x branch already hardcodes.This replaces the Arduino version check with a chip target check using
CONFIG_IDF_TARGET_*macros, so the correct port is selected regardless of Arduino version. The original classic ESP32 code path is unchanged.