Match the shark overlay report to the StandardSim report style - #68
Merged
Merged
Conversation
Use the shared BobSim title page, STIX fonts, centered titles, ruled tables, and the default axis style. The cover lists the key run facts. The full run notes move to their own page.
2 tasks done
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
The shark overlay report now uses the same style as the StandardSim reports. It uses the shared cover page, STIX fonts, centered titles, and ruled tables. The report content, metrics, and curve colors do not change.
How to check
pytest tests/test_shark_overlay_report.py tests/test_kinematics.py -qpassed (47 passed, 1 skipped).pytest tests -q: the only failures need the BobLib submodule, which was not checked out in the test worktree. The same 7 fail on unmodified main there.ruff checkpassed.make shark-overlay SHARK=tests/fixtures/rear_pushrod.shk. Compare the cover, Run Notes, summary, and headline pages withsteady_state_eval_report.pdf.Notes