feat: import hints and pub funcs discovery - #10
Merged
Conversation
gerau
approved these changes
Jul 30, 2026
Comment on lines
+1054
to
+1063
| fn items_contain_main(items: &[parse::Item]) -> bool { | ||
| items.iter().any(|item| match item { | ||
| parse::Item::Function(function) => function.name().as_inner() == "main", | ||
| parse::Item::Module(module) => items_contain_main(module.items()), | ||
| parse::Item::TypeAlias(_) | ||
| | parse::Item::Use(_) | ||
| | parse::Item::EnumDeclaration(_) | ||
| | parse::Item::Ignored => false, | ||
| }) | ||
| } |
Collaborator
There was a problem hiding this comment.
Not for this MR, but we should consider moving these functions into a separate module.
gerau
reviewed
Jul 31, 2026
Collaborator
There was a problem hiding this comment.
why we cannot put it under completion module and parse it from there?
Collaborator
Author
There was a problem hiding this comment.
Make sense, though will take a look/refactor it in a follow up PRs
| }; | ||
|
|
||
| Some( | ||
| ProjectContext::discover(path.as_ref(), &project_settings, &workspace_roots) |
Collaborator
There was a problem hiding this comment.
could we somehow cache this discover and refresh cache at Save, for example?
Collaborator
Author
There was a problem hiding this comment.
Will think about it, added to my TODOs
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.