fix(auth): document SES and fail closed on missing mail config (#1) - #385
Open
EHFCEngineering07 wants to merge 1 commit into
Open
EHFCEngineering07 wants to merge 1 commit into
EHFCEngineering07 wants to merge 1 commit into
Conversation
…oindefi#1) Document SES env vars, fail closed when they are missing, log AWS/sandbox detail server-side, and keep a generic client-facing recovery error.
|
|
EHFCEngineering07
force-pushed
the
fix/ses-password-reset-config-1
branch
2 times, most recently
from
September 28, 2026 15:42
0f5a76a to
690b049
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #1: password recovery depends on Amazon SES, but the four SES env vars were undocumented and only failed when a user requested a reset.
SES_*inapi/.env.exampleand READMEformatSesSendError/auth/password-reset/requestTest plan
pnpm exec vitest run src/tests/ses-config.test.ts.envhas verified SES identity (sandbox vs production)Made with Cursor