fix: export frontend maps during Docker build (#19) - #378
Open
slsgzs-cloud wants to merge 1 commit into
Open
slsgzs-cloud wants to merge 1 commit into
slsgzs-cloud wants to merge 1 commit into
Conversation
Author
|
Hi maintainers! This PR is mergeable and clean. It fixes a bounty issue worth $50. Would appreciate a review. |
Author
|
Hi @Rodrigoue9 @leocagli — PR #378 fixes Issue #19 (50 USD bounty). It is mergeable and clean. Could you review when you have a moment? Thank you! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
/attempt #743
Fixes #19
What
The Docker build was missing the map export step. The
frontend/public/maps_optimized/directory is generated bypnpm export-frontend-mapsin the server directory, but the Dockerfile only copied and built the frontend. This resulted in 404 errors for all map files in production.Changes
pnpm export-frontend-mapsexecution before the frontend build, so the optimized maps are available infrontend/public/when Next.js builds.Why
Issue #19 reports that Docker deployments show a blank game world with 404 errors for
/maps_optimized/*.json. The root cause is thatfrontend/.gitignoreexcludes/public/maps_optimized, and the export script was never called during Docker build.Closes #19