fix: document missing SES config and add graceful check (#1) - #377
Open
slsgzs-cloud wants to merge 2 commits into
Open
slsgzs-cloud wants to merge 2 commits into
slsgzs-cloud wants to merge 2 commits into
Conversation
7 tasks
Author
|
Hi maintainers! This PR is mergeable and clean. It fixes a bounty issue worth $20. Would appreciate a review. |
Author
|
Hi @Rodrigoue9 @leocagli — PR #377 fixes Issue #1 (20 USD bounty). It is mergeable and clean. Could you review when you have a moment? Thank you! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
/attempt #743
Fixes #1
What
.env.example: Added the 5 missing SES configuration variables (SES_REGION,SES_ACCESS_KEY_ID,SES_SECRET_ACCESS_KEY,SES_FROM_EMAIL,SES_FROM_NAME) so deployers know they need to be set.email.ts: Added anisSesConfigured()check function and a clear error message when SES is not configured, so the failure is explicit and actionable instead of a silent crash.Why
Issue #1 reports that password reset fails in production because Amazon SES is not configured. The root cause is that
.env.exampledoes not document the required SES variables, so deployers never set them. ThegetSesClient()function throws a generic error that doesn't tell the user what to do.Closes #1