fix(frontend): generate and validate maps before Docker builds - #375
Open
WilliamKwanProgramming wants to merge 1 commit into
Open
WilliamKwanProgramming wants to merge 1 commit into
WilliamKwanProgramming wants to merge 1 commit into
Conversation
Rebase Bitcoindefi#19 onto current main and test canonical exporter failure on missing terrain.
Author
|
@leocagli PR #375 is submitted within the assignment window. GitHub is currently holding the repository CI/Secret Scan with “workflows awaiting approval” for this fork PR. The same commit already passed the full CI and Secret Scan on my fork, including Docker/final-image map validation. When convenient, could you approve the upstream workflows so the required checks can run? Thanks. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #19
Assigned by @leocagli: #19 (comment)
Fixes clean Docker builds shipping without map assets. Generates maps in a separate Docker stage with the unchanged canonical exporter, preserves server/mapas_source for NPC loading, and validates every source map ID before the frontend build. Adds README instructions, regression tests, and final-image map validation in CI.
Rebased onto upstream main 0683f86. Five map-validation tests and the new missing-terrain exporter regression pass locally; all 294 real maps export and validate. The missing-terrain test verifies exit 1 against a successful two-map control.
All five fresh CI jobs passed (protocol, API, server, frontend, Docker), including final-image map validation. Secret Scan also passed.
CI: https://github.com/WilliamKwanProgramming/OpenAO/actions/runs/35150445334
Docker is unavailable locally; Docker validation runs in CI. No interactive game-rendering test is claimed. Prepared with AI assistance. Payment, if awarded, is handled through GrantFox.