Filter negated evidence from Aragorn creative results#127
Open
cbizon wants to merge 2 commits into
Open
Conversation
- Traverse bound edges and recursive support graphs before synthesizing inferred answers. - Prune negated parallel bindings while preserving analyses that retain valid support. - Drop analyses with unresolved or wholly invalid query-edge evidence and add regression coverage.
Contributor
Author
|
I worry that this approach will be slow for large queries. @maximusunc what do you think? |
- Exit after a single edge scan when no negated assertions are present. - Build reverse edge and auxiliary-graph dependencies only for affected messages. - Propagate negated and incomplete support status once, then filter bindings with constant-time lookups. - Add coverage proving the common no-negation path skips index construction.
Contributor
Author
|
Follow-up optimization in
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
biolink:negated=true.Testing
uv run --no-sync pytest tests/unit/test_merge_message_helpers.py tests/unit/test_merge_message.py tests/unit/test_merge_message_batch.py -q(45 passed).uv run --no-sync pytest tests/unit --ignore=tests/unit/test_cpu.py -q(447 passed).uv run --no-sync black --check workers/merge_message/worker.py tests/unit/test_merge_message_helpers.py.git diff --check.