Enable faulthandler from interpreter start (PYTHONFAULTHANDLER=1)#125
Merged
Conversation
The SIGABRT-on-timeout diagnostic only dumps a stack if faulthandler is active in the target child. We enable it in _init_pool_worker (the pool initializer), which runs AFTER a spawned child re-imports the worker module -- so a child that hangs during that import phase (module-level setup) gets no dump when SIGABRT'd, which is exactly the omnicorp symptom (no "Start omnicorp", no traceback). Set PYTHONFAULTHANDLER=1 in the CPU-worker images so faulthandler is armed from the very first instruction, covering the import phase too. The next hang's SIGABRT then dumps the exact frame even if the child is stuck in startup. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01TiiFCcToq8LgiEeaQhQM5e
Codecov Report✅ All modified and coverable lines are covered by tests. Continue to review full report in Codecov by Harness.
🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The SIGABRT-on-timeout diagnostic only dumps a stack if faulthandler is active in the target child. We enable it in _init_pool_worker (the pool initializer), which runs AFTER a spawned child re-imports the worker module -- so a child that hangs during that import phase (module-level setup) gets no dump when SIGABRT'd, which is exactly the omnicorp symptom (no "Start omnicorp", no traceback).
Set PYTHONFAULTHANDLER=1 in the CPU-worker images so faulthandler is armed from the very first instruction, covering the import phase too. The next hang's SIGABRT then dumps the exact frame even if the child is stuck in startup.
Claude-Session: https://claude.ai/code/session_01TiiFCcToq8LgiEeaQhQM5e