Repository navigation
Add binary E2E coverage and fix exposed runtime regressions - #226
Merged
Merged
Conversation
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What and why
Adds a standalone black-box suite that accepts a BetterWright executable or tests
betterwrighton PATH. The suite imports no target source/package internals, so it can exercise a built checkout or a separately installed release.--require-all, and atomic JSON reports with explicit failures, skips, incomplete runs, and coverage limits. The existing Node tests job runs the strict suite and uploads its report.docs/binary-e2e.md; the suite complements rather than replaces unit, type, platform, and Electron tests.bun run test:e2e bun run test:e2e /absolute/path/to/betterwright bun run test:e2e --binary bun --binary-arg "$PWD/dist/bin/betterwright.js" --require-allRegressions exposed and fixed
human.type(..., { clear: false })now positions the caret at the end for normal typing as well as fallback insertion.setContentpages whose URL remainsabout:blank.patchright-core; Bun 1.4's handling of Node loader registration no longer silently leaves the stock driver active.Verification
tests/e2e/, run outside the checkout againstbetterwrighton PATH with Bun 1.4.0 and--require-all: 102 passed, 0 failed, 0 skipped (100 cases plus 2 prerequisite checks).bun run lint,bun run typecheck,bun run test:types,bun run build:harness,bun run check:versions, andbun run check:buildpass. Lint retains existing warnings.dist/files to those exercised by the standalone run.Public API declarations and dependency pins are unchanged. Required CI display names are preserved; the new artifact action is SHA-pinned. No test imports the worker entrypoint. The separately requested local worker-refactor plan is excluded from Git and is not part of this PR.