Skip to content

Dockerfile: Changes to make Yarn work reliably #86

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
awilfox wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Dockerfile: Changes to make Yarn work reliably #86

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 15 additions & 4 deletions Dockerfile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,7 @@ RUN apt-get update -qq
RUN apt-get install -y --no-install-recommends \
bash \
curl \
default-jre \
default-jre-headless \
ca-certificates \
libpq-dev \
libvips42 \
Expand All @@ -39,9 +39,12 @@ RUN apt-get install -y --no-install-recommends \
RUN curl -fsSL https://deb.nodesource.com/setup_24.x | bash - \
&& apt-get install -y --no-install-recommends nodejs

# Set the path for node modules so we can copy them from dev to prod.
ENV NODE_PATH=/usr/local/yarn/node_modules

# Use Yarn via Corepack to avoids using reops and GPG keys
RUN corepack enable \
&& corepack prepare yarn@stable --activate \
&& corepack prepare yarn@1.22.22 --activate \

@anarchivist anarchivist Jul 13, 2026

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is this effectively downgrading yarn from our past images?

@awilfox awilfox Jul 14, 2026

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It installed a stable yarn that was never used, because the package specified 1.22.22. This just ensures it downloads that version the first time, so it doesn't waste the time of fetching a useless one.

&& yarn -v

# By default, run as the geodata user
Expand All @@ -51,7 +54,7 @@ USER $APP_USER
WORKDIR /opt/app

# Add binstubs to the path.
ENV PATH="/opt/app/bin:$PATH"
ENV PATH="/opt/app/bin:$NODE_PATH/.bin:$PATH"

# If run with no other arguments, the image will start the rails server by
# default. Note that we must bind to all interfaces (0.0.0.0) because when
Expand All @@ -74,6 +77,8 @@ RUN apt-get install -y --no-install-recommends \
g++ \
make

RUN mkdir -p /usr/local/yarn && chown $APP_USER:$APP_USER /usr/local/yarn

# Drop back to the GeoData user
USER $APP_USER

Expand All @@ -85,7 +90,10 @@ RUN bundle install
COPY --chown=geodata . .

# Install JavaScript dependencies required by cssbundling-rails.
RUN yarn install
COPY ./package.json /usr/local/yarn
RUN yarn install --cwd /usr/local/yarn
RUN cp /usr/local/yarn/yarn.lock /opt/app/
RUN ln -s /usr/local/yarn/node_modules /opt/app/node_modules

# Create cache/pids/etc directories.
RUN bundle exec -- rails log:clear tmp:create \
Expand All @@ -101,6 +109,9 @@ FROM base AS production
# Copy the built codebase from the dev stage
COPY --from=development --chown=geodata /opt/app /opt/app
COPY --from=development --chown=geodata /usr/local/bundle /usr/local/bundle
COPY --from=development --chown=geodata /usr/local/yarn /usr/local/yarn
RUN cp /usr/local/yarn/yarn.lock /opt/app/
RUN ln -s /usr/local/yarn/node_modules /opt/app/node_modules

# Sanity-check that the bundle is correctly installed, that the Gemfile
# and Gemfile.lock are synced, and that assets are able to be compiled.
Expand Down
Loading