Address minor errors from #125 and #170 - #172
Conversation
|
Previous builds had the error I also switched the CI badge, which was updated in #170 to the new rootstock CI but not the CI for this repository. Interestingly, it looks like draft pull requests on GitHub don't trigger CI builds on travis-ci.org. It works with the new travis-ci.com GitHub app. |
|
@dhimmel I'm also wondering whether we should revert the |
|
Ah yes these two lines are wrong: Lines 52 to 53 in 1b43084 They should be |
Drafts do trigger CI on travis-ci.com? IIRC draft PRs haven't triggered any travis builds for me. A real annoying bug. I didn't see an issue here, but we probably should open one. |
All the pandoc examples of header identifiers in the docs aren't directly followed by text. It doesn't seem to mention a newline is necessary, but perhaps this is intended. It could also be a pandoc bug. |
No problem, updated in fae4239
They triggered on this WIP draft pull request gitter-lab/SINGE#13 I'm not sure what we did differently there to get it to work. |
This build is based on a7c7713. This commit was created by the following Travis CI build and job: https://travis-ci.org/Benjamin-Lee/deep-rules/builds/512824962 https://travis-ci.org/Benjamin-Lee/deep-rules/jobs/512824963 [ci skip] The full commit message that triggered this build is copied below: Merge pull request #172 from agitter/minor-errors Address minor errors from #125 and #170
This build is based on a7c7713. This commit was created by the following Travis CI build and job: https://travis-ci.org/Benjamin-Lee/deep-rules/builds/512824962 https://travis-ci.org/Benjamin-Lee/deep-rules/jobs/512824963 [ci skip] The full commit message that triggered this build is copied below: Merge pull request #172 from agitter/minor-errors Address minor errors from #125 and #170
3 participants
Did you add yourself as a contributor if this is your first contribution?
Any more details?
(see below)