Convert JMB 2nd Test Portal to Markdown, label client, decode VIN manufacturers - #50
Convert JMB 2nd Test Portal to Markdown, label client, decode VIN manufacturers#50fsu9913-gif wants to merge 2 commits into
Conversation
… manufacturer lookup Co-authored-by: fsu9913-gif <fsu9913-gif@users.noreply.github.com>
Deploying with
|
| Status | Name | Latest Commit | Updated (UTC) |
|---|---|---|---|
| ❌ Deployment failed View logs |
dmc-properties | 3fb89e4 | Jul 27 2026, 08:19 PM |
There was a problem hiding this comment.
Pull request overview
Adds a client-facing Markdown version of the JMB “2nd Test Portal” schedule artifact for July–December 2026, preserving the schedule data while making it easier to edit/review in-repo.
Changes:
- Adds a Markdown schedule table (July–December 2026) with a Client column set to
JMBfor each row. - Adds a Likely Manufacturer column derived from VIN WMI decoding, with an explicit caveat about manufacturer vs. legal ownership.
- Documents two
1NKWMI entries as Unconfirmed and links to NHTSA’s VIN decoder for manual verification.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
|
||
| ## Logic Summary | ||
|
|
||
| Direct mapping for July–September due dates. 6-month extension applied for Feb–June due dates to fulfill the bi-annual testing requirement. |
| - **Irish Palette:** Emerald green headers/borders, clean white backgrounds, vibrant orange for callouts and warning statuses (like "Fail"). | ||
| - **Interactive Design:** Rows had a subtle hover effect to help track information visually. | ||
| - **Clean Hierarchy:** Grouped by month with clear, bold headers separating schedule phases. | ||
| - **Client-Ready:** Included a "Logic Summary" note explaining the bi-annual shift to the client. |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 74d0fd99c4
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
|
|
||
| \* Manufacturer is identified from the VIN's World Manufacturer Identifier (WMI, the first 3 characters), which encodes the vehicle's maker — not the registered/legal owner. Vehicle ownership is private DMV/registration data and cannot be derived from a VIN. | ||
|
|
||
| † Truck #117 (`1NKDX4TX0EJ966975`) and #121 (`1NKZX4TX9MJ972021`) share the WMI `1NK`, which isn't a WMI code I can confirm with high confidence from standard references. This environment's network egress policy blocks live lookups against the NHTSA VIN decoder (`vpic.nhtsa.dot.gov`), so I couldn't verify it against the authoritative database. To confirm, run these two VINs through [NHTSA's free VIN decoder](https://vpic.nhtsa.dot.gov/decoder/) or ask the user to whitelist that domain for this agent. |
There was a problem hiding this comment.
Decode the 1NK rows as Kenworth
For the two rows whose VINs start with 1NK, the manufacturer is not actually unknown: DOT/NHTSA-backed VIN data for 1NKDX4TX0EJ966975 returns Make KENWORTH / Manufacturer KENWORTH TRUCK COMPANY, and the carrier listing for 1NKZX4TX9MJ972021 identifies it as a 2021 Kenworth T880. Leaving them as Unconfirmed means the client-facing schedule is missing decoded manufacturers for two trucks even though the WMI can be resolved.
Useful? React with 👍 / 👎.
…7/29 PM) Co-authored-by: fsu9913-gif <fsu9913-gif@users.noreply.github.com>
|
|
||
| \* Manufacturer is identified from the VIN's World Manufacturer Identifier (WMI, the first 3 characters), which encodes the vehicle's maker — not the registered/legal owner. Vehicle ownership is private DMV/registration data and cannot be derived from a VIN. | ||
|
|
||
| † Truck #117 (`1NKDX4TX0EJ966975`) and #121 (`1NKZX4TX9MJ972021`) share the WMI `1NK`, which isn't a WMI code I can confirm with high confidence from standard references. This environment's network egress policy blocks live lookups against the NHTSA VIN decoder (`vpic.nhtsa.dot.gov`), so I couldn't verify it against the authoritative database. To confirm, run these two VINs through [NHTSA's free VIN decoder](https://vpic.nhtsa.dot.gov/decoder/) or ask the user to whitelist that domain for this agent. |
| |---|---|---|---|---|---|---| | ||
| | July 2026 | JMB | 95 | 1FVHCYCY8FHGE7317 | OBD | Pass | Freightliner | | ||
| | July 2026 | JMB | 116 | 2NPLLZ0X15M874818 | OVI | Pass | Peterbilt (Canada-built) | | ||
| | July 2026 | JMB | 117 | 1NKDX4TX0EJ966975 | OBD | Pending — scheduled Tue 7/28 or Wed 7/29 (PM)‡ | Unconfirmed† | |
Adds
JMB-SECOND-HALF.md, a Markdown version of the existingJMB-SECOND-HALFHTML fleet-testing schedule artifact (2nd Test Schedule Portal, July–December 2026).Changes from the original HTML:
JMBon every row.1FV/1FVA→ Freightliner,1XK→ Kenworth,1XP→ Peterbilt,1FD→ Ford,JALE→ Isuzu,3AL→ Freightliner (Mexico-built),2NP/3FR→ Peterbilt/Ford (Canada/Mexico-built variants).Notes/caveats included in the doc:
1NK, which I couldn't confirm with high confidence. This sandbox's network egress policy blocksvpic.nhtsa.dot.gov(NHTSA's official VIN decoder), so I flagged those as unconfirmed rather than guessing, and linked the decoder for manual verification.Follow-up update: truck #117's July 2026 OBD test was incorrectly marked "Pass" — flagged it as
Pendingsince it still needs to be tested (scheduled Tue 7/28 or Wed 7/29 afternoon), with a footnote to update it once the test is done.The original
JMB-SECOND-HALFHTML file is left untouched.