Repository navigation
Add Cohort.load() and Study.load() for reattaching executed results - #294
Merged
Merged
Conversation
a-hartens
reviewed
Sep 8, 2026
a-hartens
left a comment
Collaborator
There was a problem hiding this comment.
this looks great. the only thing missing is the characteristics_table! could you add that the same way that subset_tables_entry/index are recomputed if not written? otherwise looks great!
Collaborator
Author
Hi! Load for the characteristics table now added. |
a-hartens
approved these changes
Oct 15, 2026
| return path_exec_dir_study | ||
|
|
||
| @contextmanager | ||
| def _with_study_reporters(self, cohort): |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
load()points a cohort or study back at the tables a previousexecute()already wrote, without recomputing anything. In a fresh session, re-run the cells that define the study, skipexecute().phenex/core/cohort.py: rebuilds the plan in memory, asks the destination once, records where each step's table lives, fetches only the index table.phenex/core/study.py: load parents before subcohorts, one destination listing per connector, passed down to each cohort.phenex/core/subcohort.py: loads the parent first if needed then subcohorts.phenex/ibis_connect.py:list_dest_tables()added to the Snowflake, DuckDB and Postgres connectors.