Skip to content

fix (loaders/OBJ): fix a typo that cause the obj loader not loading v…#18318

Merged
sebavan merged 1 commit intoBabylonJS:masterfrom
FairySunny:master
Apr 15, 2026
Merged

fix (loaders/OBJ): fix a typo that cause the obj loader not loading v…#18318
sebavan merged 1 commit intoBabylonJS:masterfrom
FairySunny:master

Conversation

@FairySunny
Copy link
Copy Markdown
Contributor

The obj file loader does not load vertex colors into the final mesh (with option importVertexColors on) because of a typo (_wrappedColorsForBabylon -> _unwrappedColorsForBabylon).

@RaananW
Copy link
Copy Markdown
Member

RaananW commented Apr 15, 2026

/azp run

@azure-pipelines
Copy link
Copy Markdown

Azure Pipelines successfully started running 1 pipeline(s).

@bjsplat
Copy link
Copy Markdown
Collaborator

bjsplat commented Apr 15, 2026

Please make sure to label your PR with "bug", "new feature" or "breaking change" label(s).
To prevent this PR from going to the changelog marked it with the "skip changelog" label.

@bjsplat
Copy link
Copy Markdown
Collaborator

bjsplat commented Apr 15, 2026

Snapshot stored with reference name:
refs/pull/18318/merge

Test environment:
https://snapshots-cvgtc2eugrd3cgfd.z01.azurefd.net/refs/pull/18318/merge/index.html

To test a playground add it to the URL, for example:

https://snapshots-cvgtc2eugrd3cgfd.z01.azurefd.net/refs/pull/18318/merge/index.html#WGZLGJ#4600

Links to test your changes to core in the published versions of the Babylon tools (does not contain changes you made to the tools themselves):

https://playground.babylonjs.com/?snapshot=refs/pull/18318/merge
https://sandbox.babylonjs.com/?snapshot=refs/pull/18318/merge
https://gui.babylonjs.com/?snapshot=refs/pull/18318/merge
https://nme.babylonjs.com/?snapshot=refs/pull/18318/merge

To test the snapshot in the playground with a playground ID add it after the snapshot query string:

https://playground.babylonjs.com/?snapshot=refs/pull/18318/merge#BCU1XR#0

If you made changes to the sandbox or playground in this PR, additional comments will be generated soon containing links to the dev versions of those tools.

@bjsplat
Copy link
Copy Markdown
Collaborator

bjsplat commented Apr 15, 2026

@bjsplat
Copy link
Copy Markdown
Collaborator

bjsplat commented Apr 15, 2026

@bjsplat
Copy link
Copy Markdown
Collaborator

bjsplat commented Apr 15, 2026

@sebavan sebavan merged commit 6b8a500 into BabylonJS:master Apr 15, 2026
22 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants