Fix "/divinemc" being visible even when a player has no access to any sub-commands. - #68
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Suggestion
I would like to suggest restricting the base permission node of the "/divinemc" command to operators.
At present, "/divinemc" is visible in tab complete even when players don't have access to any of the utilities within it. There is no need for the command to be listed if the player has no access to any of the sub-commands. Regular players do not need the base permission node either, as all of the sub-commands are now restricted to operators.
Changes
This pull request changes the default value of the base permission node to "OP". This fixes the tab complete issue.