Update default permissions for the "/divinemc" command. - #62
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Suggestion
I would like to suggest changing the default value for some of the permission nodes added by the "/divinemc" command.
At present, all players can execute "/divinemc mspt". Access to the performance data should always be restricted for security reasons. Thus, the "/divinemc mspt" command should only be available to operators by default, just like with the regular "/mspt" command.
Regular players do not need access to "/divinemc version" either. This command should be restricted to operators as well, just like with the "/purpur version" command.
Changes
This pull request changes the default value of the permission node for the "mspt" and "version" subcommands. Instead of them being granted to all players, the code makes it so that the permission nodes are only granted to operators by default. However, any server owner can still override this using a permissions plugin.