Repository navigation
Deploy a preview again when a pull request opens without one - #37
Closed
plmercereau wants to merge 1 commit into
Closed
plmercereau wants to merge 1 commit into
plmercereau wants to merge 1 commit into
Conversation
Vercel deploys on push, not when a pull request opens. A branch whose pull request was closed lost its previews to our cleanup, and opening a new pull request on the same commit did not bring one back (#34, #35). Claude-Session: https://claude.ai/code/session_01BLKZu4E8T123xzXASL2erH
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Collaborator
Author
|
End-to-end test done on this pull request. Closing it ran the delete job ( |
Collaborator
Author
|
Closed on the maintainer's decision: the workflow stays as it is on main. A pull request that loses its preview after a close and reopen gets one back with a new push, for example an empty commit. |
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
Pull request #35 had no preview. Its branch had been opened as #34, closed 49 seconds later, and opened again as #35 on the same commit. Closing #34 ran our cleanup workflow, which deleted the branch's preview (
Deleting dpl_Cqi8UMN3MZpTX2G9hhkt7XGuQiyein its log). Vercel deploys on push, not when a pull request opens, so #35 got nothing, while its Vercel status still pointed at the deleted deployment.What changes
openedandreopened. A second job looks for a deployment of the head commit and, when there is none, creates one through Vercel's API from the branch.closedjob is unchanged.preview-deployments.yml, since it no longer only deletes. ADR 0004 gets a sentence.Checks
https://claude.ai/code/session_01BLKZu4E8T123xzXASL2erH