Skip to content

SNT-333: Define rule exceptions at higher level than district - #397

Merged
Bewi merged 3 commits into
developfrom
feat/SNT-333-users-can-define-exceptions-at-other-levels-than-district-province-region
Oct 5, 2026
Merged

Bewi merged 3 commits into
developfrom
feat/SNT-333-users-can-define-exceptions-at-other-levels-than-district-province-region

Conversation

@Bewi

@Bewi Bewi commented Sep 28, 2026

Copy link
Copy Markdown
Collaborator

What problem is this PR solving?

Define rule exceptions at higher level than district

Related JIRA tickets

SNT-333

Changes

  • Add a new OrgUnit tree selector,
  • Replace the inclusion / exclusion inputs with the new component.
  • Remove "all org units", this can be achieve by selecting the root of the org unit tree.
  • Exclusion list will only contains org unit that are part of the criteria.

How to test

Go to a Scenario and play with the OrgUnit tree selector.
It should:

  • Unselect an OU from the criteria should be marked as excluded.
  • Including and excluded OU resets it to the criteria matching state.
  • Selecting an OU not matching the criteria should be highlighted more.
  • Unselecting an OU not matching the criteria just removes it from the list.
  • Searching OU and changing the selection only impact search result scope

Print screen / video

image

Notes

N/A

Doc

N/A

@Bewi
Bewi requested a review from michiwend September 28, 2026 12:33
@Bewi
Bewi force-pushed the feat/SNT-333-users-can-define-exceptions-at-other-levels-than-district-province-region branch from 9385e6e to 10e80de Compare September 29, 2026 11:57
@Bewi
Bewi force-pushed the feat/SNT-333-users-can-define-exceptions-at-other-levels-than-district-province-region branch from 10e80de to 00edaaa Compare September 29, 2026 12:01

@michiwend michiwend left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM and works well.

The two main issues I found when testing

  • Not being able to see where overrides happen when the tree is collapsed (discussed, we can work on it in the upcoming rule builder changes)

  • The chat AI integration is behind the capabilities of the tree selector. It probably had already been before but now even more so because you can additionally also include/exclude provinces etc. Also not a blocker, recorded a follow-up ticket here

    Image

@Bewi
Bewi merged commit 89505d0 into develop Oct 5, 2026
6 checks passed
@Bewi
Bewi deleted the feat/SNT-333-users-can-define-exceptions-at-other-levels-than-district-province-region branch October 5, 2026 13:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants