Repository navigation
fix(push): deleted data points (NA) logging - #18
Merged
Merged
Conversation
lgarridobsq
approved these changes
Sep 29, 2026
lgarridobsq
left a comment
lgarridobsq
left a comment
Collaborator
There was a problem hiding this comment.
Very nice, I only left 1 stupid comment -- don't forget to up the version
| f" Final summary: {self.summary['import_counts']}" | ||
| ) | ||
| self._log_message(f"{processed_points} / {total_data_points} data points processed.") | ||
| self._log_message(f"Final summary: {self.summary[summary_key]}") |
Collaborator
There was a problem hiding this comment.
You say final summary in both the cases of pushing-pushing and pushing-deleting -- ¿maybe that is a bit confusing?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Small fix to separate the import summary counts between regular imports (data points) and data points to delete (value = NA).
The current code is logging a confusing message including the total number in the summary, example below:
2026-09-11 19:24:37,608 - INFO - Pushing 6 data points with NA values.
2026-09-11 19:24:37,782 - WARNING - 6 data points will be set to NA. Please check the last execution report for details.
2026-09-11 19:24:37,915 - WARNING - 1. ...
...
2026-09-11 19:24:37,915 - WARNING - 6. ...
2026-09-11 19:25:09,631 - INFO - 6 / 6 data points processed. Final summary: {'imported': 22515, 'updated': 397, 'ignored': 2930223, 'deleted': 0}
2026-09-11 19:25:09,789 - INFO - Data points delete summary: {'imported': 22515, 'updated': 397, 'ignored': 2930223, 'deleted': 0}
After the fix the messages should be separated between imported (normal points) and deleted points for clarity.
No further functional changes.