Fix versioning for LBT - #357
Conversation
|
@BHoMBot check versioning |
|
@Tom-Kingstone to confirm, the following actions are now queued:
There are 689 requests in the queue ahead of you. |
|
@Tom-Kingstone just to let you know, I have provided a |
|
@Tom-Kingstone just to let you know, I have provided a |
jamesramsden-bh
left a comment
There was a problem hiding this comment.
Tested alongside linked Versioning_Toolkit PR, happy to merge
|
@Tom-Kingstone to confirm, the following actions are now queued:
|
|
@BHoMBot check ready-to-merge |
|
@Tom-Kingstone to confirm, the following actions are now queued:
|
NOTE: Depends on BHoM/Versioning_Toolkit#355
Issues addressed by this PR
see linked PR (and its issue) for more information
Test files
Ensure to first delete any v93.json file located in $(ProgramData)/BHoM/Upgrades/BHoMUpgrades/Upgrades
Build this branch in LadybugTools_Toolkit, then same name branch in Versioning_Toolkit in that order
Use the following json to test
FromJsonin grasshopper{ "_t": "BH.oM.LadybugTools.SimulationResult", "EpwFile": { "_t": "BH.oM.Adapter.FileSettings", "FileName": "a.epw", "Directory": "C:/Users/tkingstone/Downloads", "BHoM_Guid": "03962644-9dca-4565-a065-c27b9e78a890", "Name": "" }, "GroundMaterial": { "_t": "BH.oM.LadybugTools.EnergyMaterial", "Identifier": "a", "Thickness": 1.0, "Conductivity": 1.0, "Density": 1.0, "SpecificHeat": 2000.0, "Roughness": "MediumRough", "ThermalAbsorptance": 0.9, "SolarAbsorptance": 0.7, "VisibleAbsorptance": 0.7, "Type": "EnergyMaterial", "BHoM_Guid": "b1504b12-462f-4f96-ba25-3ec82e0865a2", "Name": "" }, "ShadeMaterial": { "_t": "BH.oM.LadybugTools.EnergyMaterial", "Identifier": "a", "Thickness": 1.0, "Conductivity": 1.0, "Density": 1.0, "SpecificHeat": 2000.0, "Roughness": "MediumRough", "ThermalAbsorptance": 0.9, "SolarAbsorptance": 0.7, "VisibleAbsorptance": 0.7, "Type": "EnergyMaterial", "BHoM_Guid": "b1504b12-462f-4f96-ba25-3ec82e0865a2", "Name": "" }, "Identifier": "a", "ShadedDownTemperature": null, "ShadedUpTemperature": null, "ShadedRadiantTemperature": null, "ShadedLongwaveMeanRadiantTemperatureDelta": null, "ShadedShortwaveMeanRadiantTemperatureDelta": null, "ShadedMeanRadiantTemperature": null, "UnshadedDownTemperature": null, "UnshadedUpTemperature": null, "UnshadedRadiantTemperature": null, "UnshadedLongwaveMeanRadiantTemperatureDelta": null, "UnshadedShortwaveMeanRadiantTemperatureDelta": null, "UnshadedMeanRadiantTemperature": null, "BHoM_Guid": "59a8a4af-09c2-4e75-977c-3dfdf537fa93", "Name": "", "ThisIsAnUnexpectedProperty": null, "_bhomVersion": "9.3" }Expect no error (red), but a warning (orange) for custom property
Changelog
Additional comments