Skip to content

Fix versioning for LBT - #357

Merged
peterjamesnugent merged 1 commit into
developfrom
Versioning_Toolkit-#354-SimulationResult
Sep 16, 2026
Merged

peterjamesnugent merged 1 commit into
developfrom
Versioning_Toolkit-#354-SimulationResult

Conversation

@Tom-Kingstone

@Tom-Kingstone Tom-Kingstone commented Sep 15, 2026

Copy link
Copy Markdown
Contributor

NOTE: Depends on BHoM/Versioning_Toolkit#355

Issues addressed by this PR

see linked PR (and its issue) for more information

Test files

Ensure to first delete any v93.json file located in $(ProgramData)/BHoM/Upgrades/BHoMUpgrades/Upgrades
Build this branch in LadybugTools_Toolkit, then same name branch in Versioning_Toolkit in that order

Use the following json to test FromJson in grasshopper

{
    "_t": "BH.oM.LadybugTools.SimulationResult",
    "EpwFile": {
        "_t": "BH.oM.Adapter.FileSettings",
        "FileName": "a.epw",
        "Directory": "C:/Users/tkingstone/Downloads",
        "BHoM_Guid": "03962644-9dca-4565-a065-c27b9e78a890",
        "Name": ""
    },
    "GroundMaterial": {
        "_t": "BH.oM.LadybugTools.EnergyMaterial",
        "Identifier": "a",
        "Thickness": 1.0,
        "Conductivity": 1.0,
        "Density": 1.0,
        "SpecificHeat": 2000.0,
        "Roughness": "MediumRough",
        "ThermalAbsorptance": 0.9,
        "SolarAbsorptance": 0.7,
        "VisibleAbsorptance": 0.7,
        "Type": "EnergyMaterial",
        "BHoM_Guid": "b1504b12-462f-4f96-ba25-3ec82e0865a2",
        "Name": ""
    },
    "ShadeMaterial": {
        "_t": "BH.oM.LadybugTools.EnergyMaterial",
        "Identifier": "a",
        "Thickness": 1.0,
        "Conductivity": 1.0,
        "Density": 1.0,
        "SpecificHeat": 2000.0,
        "Roughness": "MediumRough",
        "ThermalAbsorptance": 0.9,
        "SolarAbsorptance": 0.7,
        "VisibleAbsorptance": 0.7,
        "Type": "EnergyMaterial",
        "BHoM_Guid": "b1504b12-462f-4f96-ba25-3ec82e0865a2",
        "Name": ""
    },
    "Identifier": "a",
    "ShadedDownTemperature": null,
    "ShadedUpTemperature": null,
    "ShadedRadiantTemperature": null,
    "ShadedLongwaveMeanRadiantTemperatureDelta": null,
    "ShadedShortwaveMeanRadiantTemperatureDelta": null,
    "ShadedMeanRadiantTemperature": null,
    "UnshadedDownTemperature": null,
    "UnshadedUpTemperature": null,
    "UnshadedRadiantTemperature": null,
    "UnshadedLongwaveMeanRadiantTemperatureDelta": null,
    "UnshadedShortwaveMeanRadiantTemperatureDelta": null,
    "UnshadedMeanRadiantTemperature": null,
    "BHoM_Guid": "59a8a4af-09c2-4e75-977c-3dfdf537fa93",
    "Name": "",
    "ThisIsAnUnexpectedProperty": null,
    "_bhomVersion": "9.3"
}

Expect no error (red), but a warning (orange) for custom property

Changelog

Additional comments

@Tom-Kingstone Tom-Kingstone self-assigned this Sep 15, 2026
@Tom-Kingstone Tom-Kingstone added the type:bug Error or unexpected behaviour label Sep 15, 2026
@Tom-Kingstone

Copy link
Copy Markdown
Contributor Author

@BHoMBot check versioning

@bhombot-ci

bhombot-ci Bot commented Sep 15, 2026

Copy link
Copy Markdown

@Tom-Kingstone to confirm, the following actions are now queued:

  • check versioning

There are 689 requests in the queue ahead of you.

@jamesramsden-bh jamesramsden-bh added the status:do-not-merge For instance, test PR, for discussion, or dependant PRs not ready for merge label Sep 16, 2026
@bhombot-ci

bhombot-ci Bot commented Sep 16, 2026

Copy link
Copy Markdown

@Tom-Kingstone just to let you know, I have provided a check-versioning result to this Pull Request as it was detected to be linked to other Pull Requests in a series. The comment which triggered this check came from @Tom-Kingstone on Versioning_Toolkit

@bhombot-ci

bhombot-ci Bot commented Sep 16, 2026

Copy link
Copy Markdown

@Tom-Kingstone just to let you know, I have provided a check-installer result to this Pull Request as it was detected to be linked to other Pull Requests in a series. The comment which triggered this check came from @Tom-Kingstone on Versioning_Toolkit

@jamesramsden-bh jamesramsden-bh left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested alongside linked Versioning_Toolkit PR, happy to merge

@Tom-Kingstone

Copy link
Copy Markdown
Contributor Author

@BHoMBot check compliance
@BHoMBot check core
@BHoMBot check null-handling
@BHoMBot check serialisation
@BHoMBot check unit-tests

@bhombot-ci

bhombot-ci Bot commented Sep 16, 2026

Copy link
Copy Markdown

@Tom-Kingstone to confirm, the following actions are now queued:

  • check code-compliance
  • check documentation-compliance
  • check project-compliance
  • check branch-compliance
  • check dataset-compliance
  • check copyright-compliance
  • check core
  • check null-handling
  • check serialisation
  • check unit-tests

@Tom-Kingstone Tom-Kingstone removed the status:do-not-merge For instance, test PR, for discussion, or dependant PRs not ready for merge label Sep 16, 2026
@Tom-Kingstone

Copy link
Copy Markdown
Contributor Author

@BHoMBot check ready-to-merge

@bhombot-ci

bhombot-ci Bot commented Sep 16, 2026

Copy link
Copy Markdown

@Tom-Kingstone to confirm, the following actions are now queued:

  • check ready-to-merge

@peterjamesnugent
peterjamesnugent merged commit dee4f1d into develop Sep 16, 2026
22 checks passed
@peterjamesnugent
peterjamesnugent deleted the Versioning_Toolkit-#354-SimulationResult branch September 16, 2026 16:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

type:bug Error or unexpected behaviour

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants