Skip to content

Feature/1258 write playwright e2e test for vaultsscreen withdrawals and shares - #1299

Merged
p3ris0n merged 5 commits into
BCPathway:mainfrom
AMDYFX:feature/1258-write-playwright-e2e-test-for-vaultsscreen-withdrawals-and-shares
Oct 21, 2026
Merged

p3ris0n merged 5 commits into
BCPathway:mainfrom
AMDYFX:feature/1258-write-playwright-e2e-test-for-vaultsscreen-withdrawals-and-shares

Conversation

@AMDYFX

@AMDYFX AMDYFX commented Oct 20, 2026

Copy link
Copy Markdown
Contributor

Summary

Adds deterministic Playwright end-to-end tests for the VaultsScreen withdrawal workflow in bc-forge, covering withdrawal input validation, MAX shares selection, share redemption previews, and transaction confirmation.

Changes Made

  • Withdrawal Input Validation: Verify that invalid, empty, zero, or excessive withdrawal amounts are handled appropriately.
  • MAX Shares: Confirm that the MAX button selects the user's available share balance and updates the withdrawal interface correctly.
  • Redemption Preview: Validate the estimated redemption amount before the user submits a withdrawal.
  • Withdrawal Flow: Exercise the withdrawal workflow from wallet connection through transaction confirmation using deterministic mock wallet fixtures.
  • Balance Updates: Verify that a successful withdrawal updates the displayed share balance and triggers a success toast.
  • Error Handling: Cover disconnected wallets, RPC/network failures, and rejected transactions to ensure users receive helpful feedback without unhandled exceptions.
  • Accessibility: Add automated accessibility checks for the withdrawal screen where supported by the existing Playwright and axe-core setup.

Testing

  • Add or update react/e2e/vaults.spec.ts.
  • Verify withdrawal amount validation and boundary cases.
  • Verify MAX shares selection and redemption preview.
  • Verify successful withdrawal, balance updates, and success notification.
  • Verify disconnected wallet, network error, and rejected transaction states.
  • Ensure tests are deterministic and do not depend on live wallet interactions or external RPC availability.
  • Run npm run build --workspace @bc-forge/sdk.
  • Run npm test --workspace @bc-forge/react.
  • Run npm run build --workspace @bc-forge/react.
  • Run the applicable Playwright E2E command.

Scope

Focus on withdrawal-related E2E coverage in react/e2e/vaults.spec.ts, following existing repository conventions and reusing available wallet fixtures, test utilities, and SDK integration patterns.

Closes #1258
Closes #1260
Closes #1261
Closes #1256

@drips-wave

drips-wave Bot commented Oct 20, 2026

Copy link
Copy Markdown

@AMDYFX Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits.

You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀

Learn more about application limits

@p3ris0n
p3ris0n force-pushed the feature/1258-write-playwright-e2e-test-for-vaultsscreen-withdrawals-and-shares branch from 5a78cb2 to d6b9af4 Compare October 21, 2026 09:22
@p3ris0n
p3ris0n merged commit f2b3ee5 into BCPathway:main Oct 21, 2026
4 of 16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

2 participants