Skip to content

Faster rdc pass N on large captures - #276

Merged
BANANASJIM merged 2 commits into
BANANASJIM:masterfrom
VelocityRa:pass-cache
Oct 8, 2026
Merged

BANANASJIM merged 2 commits into
BANANASJIM:masterfrom
VelocityRa:pass-cache

Conversation

@VelocityRa

@VelocityRa VelocityRa commented Oct 8, 2026 •

Copy link
Copy Markdown
Contributor

rdc pass N rebuilt the whole pass list from the action tree on every call (3200 actions in my capture). The tree is immutable per session, so build it once and cache it.

Summary by CodeRabbit

  • Performance
    • Repeated requests for render passes now reuse previously prepared pass data, reducing redundant processing.
  • Bug Fixes
    • Per-request render-target details no longer affect cached pass data, keeping results consistent across repeated requests.

rdc pass N no longer rebuilds the whole pass list from 3200 actions on every call.

The action tree is immutable per session, so the list is built once and cached.
@VelocityRa
VelocityRa requested a review from BANANASJIM as a code owner October 8, 2026 00:06
@qodo-code-review

Copy link
Copy Markdown

ⓘ Qodo reviews are paused because the subscription is no longer active. Ask your workspace admin to reactivate the subscription to resume reviews. Manage billing

@greptile-apps greptile-apps Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Your trial has ended. Reactivate Greptile to resume code reviews.

@coderabbitai

coderabbitai Bot commented Oct 8, 2026 •

Copy link
Copy Markdown

Review in Change Stack →

Note

Currently processing new changes in this PR. This may take a few minutes, please wait...

⚙️ Run configuration
  • Configuration used: defaults
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: d4a4936e-39fe-48cb-8971-8d5dcb4d3e1a
📥 Commits

Reviewing files that changed from the base of the PR and between fe956f9 and fedfa50.

📒 Files selected for processing (4)
  • src/rdc/daemon_server.py
  • src/rdc/handlers/query.py
  • src/rdc/services/query_service.py
  • tests/unit/test_draws_events_daemon.py
 _______________________________
< Yippee-ki-yay, mother-bugger! >
 -------------------------------
  \
   \   \
        \ /\
        ( )
      .( o ).
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create a new PR
  • Autopilot · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@BANANASJIM
BANANASJIM merged commit a63e0b1 into BANANASJIM:master Oct 8, 2026
15 of 16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants