Skip to content

Raise default local open timeout to 120s - #274

Merged
BANANASJIM merged 2 commits into
BANANASJIM:masterfrom
VelocityRa:open-timeout
Oct 8, 2026
Merged

BANANASJIM merged 2 commits into
BANANASJIM:masterfrom
VelocityRa:open-timeout

Conversation

@VelocityRa

@VelocityRa VelocityRa commented Oct 7, 2026 •

Copy link
Copy Markdown
Contributor

A 3200-event GL capture needs more than 15s to load and fails with "daemon failed to start". Default to 120s locally; RDC_OPEN_TIMEOUT still overrides.

Summary by CodeRabbit

  • Bug Fixes
    • Increased the default wait time for local daemon startup to reduce timeouts during slower startups. Explicit timeout settings remain in effect.

Large captures take longer than 15s to replay-load (eg. a 3200-event GL capture), and failed with a vague 'daemon failed to start'.
@VelocityRa
VelocityRa requested a review from BANANASJIM as a code owner October 7, 2026 23:30
@qodo-code-review

Copy link
Copy Markdown

ⓘ Qodo reviews are paused because the subscription is no longer active. Ask your workspace admin to reactivate the subscription to resume reviews. Manage billing

@greptile-apps greptile-apps Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Your trial has ended. Reactivate Greptile to resume code reviews.

@coderabbitai

coderabbitai Bot commented Oct 7, 2026 •

Copy link
Copy Markdown

Review in Change Stack →

Important

Review skipped

Review was skipped as selected files did not have any reviewable changes.

⚙️ Run configuration
  • Configuration used: defaults
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: 6d66b7a8-da0c-4c6d-8eff-a3d2c8684fd3
📥 Commits

Reviewing files that changed from the base of the PR and between f5d6034 and e90c5f1.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration
  • Configuration used: defaults
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: b61d3885-5de8-42ea-9ac7-47e9e9fd81df
📥 Commits

Reviewing files that changed from the base of the PR and between ae559ee and f5d6034.

📒 Files selected for processing (1)
  • src/rdc/services/session_service.py

Included review availability: This review used your included allowance. Your plan provides up to 2 included reviews per hour; 0 remain after this review.


📝 Walkthrough

Walkthrough

The local daemon startup timeout default increases from 15 to 120 seconds. The remote default remains 300 seconds. Explicit timeout values and RDC_OPEN_TIMEOUT retain precedence.

Changes

Startup timeout

Layer / File(s) Summary
Local startup timeout default
src/rdc/services/session_service.py
The default timeout for local daemon startup increases from 15 to 120 seconds. The remote default remains 300 seconds. Explicit timeout values and RDC_OPEN_TIMEOUT still take precedence.

Priority: ➖ Normal

Estimated code review effort: 1 (Trivial) | ~3 minutes

Change: Bug fix

Merge Risk: ⚪ Minimal · up to f5d60

Local opens have more time to load large captures. Failed opens can take longer across retries, but no repository contract establishes that this exceeds the configured timeout’s intended scope; no actionable merge-blocking risk is established.

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Docstring Coverage ⚠️ Warning Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 2 functions across 1 files. Write docstrings for the functions missing them to satisfy the coverage threshold.
✅ Passed checks (4 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly and concisely states the main change: increasing the default local open timeout to 120 seconds.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create a new PR
  • Autopilot · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

Comment thread src/rdc/services/session_service.py

@greptile-apps greptile-apps Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Your trial has ended. Reactivate Greptile to resume code reviews.

@BANANASJIM
BANANASJIM merged commit 5cb5b4e into BANANASJIM:master Oct 8, 2026
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants