You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
docs: follow-ups to the snippet audit (docs-site pages missing canisterId, v8-only idleOptions JSDoc, stale example headers, CanisterError.details type) #685
Follow-ups from the AI-context and README snippet audit (#674–#679). The audit fixed the llms files, the skills and the package READMEs; these are the same defects elsewhere, plus one possible library issue.
JSDoc.defineReactor's auth option and idleOptions don't say that idleOptions works only with @icp-sdk/auth v8. v10 drops it with a warning.
Example headers. The legacy examples/tanstack-router hook files still carry "Auto-generated by @ic-reactor/cli" headers, although codegen no longer produces them.
Possible library issue, unproven.CanisterError.details is typed as a Map, but it holds whatever the canister's details field was. Check it against real canister error shapes. If the type is wrong, fix it in core.
Follow-ups from the AI-context and README snippet audit (#674–#679). The audit fixed the llms files, the skills and the package READMEs; these are the same defects elsewhere, plus one possible library issue.
tanstack-router.mdxcalls thehooks/files "generated", but current codegen doesn't write them.cli.mdxdoesn't document the per-canistercanisterIdoption, and without it the generated reactor throws on import in Node and on a deployed site (docs(cli): the README's example config generates a reactor that throws on import; thecanisterIdoption is undocumented #677). Other pages may also be missingcanisterIdin their setup snippets (docs(ai-context): llms-full.txt and the hooks skill teach setups that throw, a nonce that fails tsc, and "generated" files codegen no longer writes #674).defineReactor'sauthoption andidleOptionsdon't say thatidleOptionsworks only with@icp-sdk/authv8. v10 drops it with a warning.examples/tanstack-routerhook files still carry "Auto-generated by @ic-reactor/cli" headers, although codegen no longer produces them.CanisterError.detailsis typed as aMap, but it holds whatever the canister'sdetailsfield was. Check it against real canister error shapes. If the type is wrong, fix it in core.B3Pay/ic-reactor-skillscopy ofSKILL.mdneeds the same changes as docs(ai-context): llms-full.txt and the hooks skill teach setups that throw, a nonce that fails tsc, and "generated" files codegen no longer writes #674. It lives in another repository, so it's listed here for the maintainer.Acceptance
mainand fixed, or shown to be correct.