Repository navigation
Anporumb/sf 11 9 121 - #407
Merged
Merged
Conversation
We no longer look for debug SF libs, so the /NODEFAULTLIB:MSVCRT Debug option on FabricUUIDInternal is the permanent mechanism, not a stopgap. - CMakeLists.txt: replace the TODO (waiting for a debug package) with a recheck note; dumpbin confirms InternalFabricUUID.lib in 11.9.121-internal (x64 and win-arm64) still embeds /DEFAULTLIB:MSVCRT. - readme.md: state the retail-only decision, record the last debug package version (10.1.1951-internal), describe the MSVCRT cost and the per-bump dumpbin check, drop the link to the manual debug pull. - doc/how_to.md: mark as historical. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Copilot-Session: 40c4358b-aaf4-4d0b-b3d2-04f4782ff933
doc/how_to.md described manually pulling debug SF libs from the reddog drop. sf-c-util links the retail NuGet libs in every configuration and no longer looks for debug libs, so the procedure and the 6 screenshots used only by it are removed. Nothing else referenced them. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Copilot-Session: 40c4358b-aaf4-4d0b-b3d2-04f4782ff933
|
Azure Pipelines: There may be pipelines that require an authorized user to comment /azp run to run. |
anporumb
enabled auto-merge (squash)
November 2, 2026 18:49
Contributor
Author
|
/azp run |
|
Azure Pipelines: Successfully started running 1 pipeline(s). |
In 11.9.121-internal (x64 and win-arm64) FabricUUID.lib and InternalFabricUUID.lib are compiled /Zi and reference *.StaticLibrary.compile.pdb, which no SF NuGet ships (11.8.121 and 12.0.997-internal-beta are /Z7). Linking with /DEBUG raises LNK4099, promoted to LNK1218 by /WX. Add /IGNORE:4099 to INTERFACE_LINK_OPTIONS of FabricUUID and FabricUUIDInternal. The libs only hold GUID/IID data, so no useful debug info is lost. Document the per-bump dumpbin check in readme.md. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Copilot-Session: 40c4358b-aaf4-4d0b-b3d2-04f4782ff933
Contributor
Author
|
/azp run |
|
Azure Pipelines: Successfully started running 1 pipeline(s). |
Contributor
Author
|
/azp run |
|
Azure Pipelines: Successfully started running 1 pipeline(s). |
anporumb
force-pushed
the
anporumb/sf_11_9_121
branch
from
November 2, 2026 21:17
a4ec719 to
f1fa437
Compare
Contributor
Author
|
/azp run |
|
Azure Pipelines: Successfully started running 1 pipeline(s). |
Dan Cristoloveanu (dcristoloveanu)
approved these changes
Nov 2, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.