Skip to content

Extend web push support - #320

Open
MarkusEngelHahnSoftware wants to merge 3 commits into
Azure:mainfrom
MarkusEngelHahnSoftware:extend_web_push_support
Open

Extend web push support#320
MarkusEngelHahnSoftware wants to merge 3 commits into
Azure:mainfrom
MarkusEngelHahnSoftware:extend_web_push_support

Conversation

@MarkusEngelHahnSoftware

Copy link
Copy Markdown

Hi,
this adds some missing annotations for the recently added BrowserRegistrationDescriptions and registers them with the serializer. Besides that, I added some convenience methods to NotificationHubClient in accordance with the already existing ones.

Things to consider before you submit the PR:

  • Are tests passing locally?
  • Are the files formatted correctly?
  • Did you add unit tests?
  • Did you test your change with either the sample apps that are included in the repository or with a blank app that uses your change?

Related PRs or issues

#314

Misc

"CreateBrowserTemplateRegistrationAsync" methods are currently not added it INotificationHubClient.

@MarkusEngelHahnSoftware

Copy link
Copy Markdown
Author

@microsoft-github-policy-service agree company="Hahn Softwareentwicklung GmbH"

@timvandesteeg

Copy link
Copy Markdown

Can someone please review this PR?

@lomagdal2

Copy link
Copy Markdown
Member

lgtm

@lomagdal2 lomagdal2 self-assigned this Jul 1, 2024
@PaulLoganCamden

Copy link
Copy Markdown

lgtm

Hey lomagdal2, I'm nervously excited about you getting this one over the finish line. 😬😃

Do you have any idea when you will have the time to wrap this one up?

Many, many thanks,

Paul.

@PaulLoganCamden

Copy link
Copy Markdown

Hey lomagdal2 , any chance of a Friday treat? 🍦

@curlybapchap

Copy link
Copy Markdown

😴🥺😩 lomagdal2

@PaulLoganCamden

Copy link
Copy Markdown

😴🥺😩🧟‍♂️💀 lomagdal2

@curlybapchap

Copy link
Copy Markdown

lomagdal2
image

@PaulLoganCamden

Copy link
Copy Markdown

Numbers say it all....
image

@curlybapchap

Copy link
Copy Markdown

FFS!!!!

Press the flippin button 🤬

@stasnovogursky

Copy link
Copy Markdown

Pleeeeeeease aprove!

@sreehari-ms

Copy link
Copy Markdown

Hello folks! Apologies for the late reply. We are currently working on enhancing our core security for ANH and have added this task into our backlog. We will keep you posted once we review and merge the code. Thanks for using ANH for your notification needs.

@SpikeViper

Copy link
Copy Markdown

The absolute glacial pace of such a core package being updated makes me question using Azure for my project. Microsoft's own cloud service doesn't have an updated SDK in their own language? Come on.

@IndumoMetob

Copy link
Copy Markdown

Sreehari R (@sreehari-ms) I guess your silence means this SDK is dead?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

10 participants