Extend web push support - #320
Conversation
|
@microsoft-github-policy-service agree company="Hahn Softwareentwicklung GmbH" |
|
Can someone please review this PR? |
|
lgtm |
Hey lomagdal2, I'm nervously excited about you getting this one over the finish line. 😬😃 Do you have any idea when you will have the time to wrap this one up? Many, many thanks, Paul. |
|
Hey lomagdal2 , any chance of a Friday treat? 🍦 |
|
😴🥺😩 lomagdal2 |
|
😴🥺😩🧟♂️💀 lomagdal2 |
|
FFS!!!! Press the flippin button 🤬 |
|
Pleeeeeeease aprove! |
|
Hello folks! Apologies for the late reply. We are currently working on enhancing our core security for ANH and have added this task into our backlog. We will keep you posted once we review and merge the code. Thanks for using ANH for your notification needs. |
|
The absolute glacial pace of such a core package being updated makes me question using Azure for my project. Microsoft's own cloud service doesn't have an updated SDK in their own language? Come on. |
|
Sreehari R (@sreehari-ms) I guess your silence means this SDK is dead? |


Hi,
this adds some missing annotations for the recently added BrowserRegistrationDescriptions and registers them with the serializer. Besides that, I added some convenience methods to NotificationHubClient in accordance with the already existing ones.
Things to consider before you submit the PR:
Related PRs or issues
#314
Misc
"CreateBrowserTemplateRegistrationAsync" methods are currently not added it INotificationHubClient.