Repository navigation
fix: remove PATCH+1 version heuristic from VSIX builds - #85
Merged
Merged
Conversation
The old logic in ci.yml and staging.yml auto-bumped PATCH+1 when HEAD was not an exact tag match, causing VSIX versions to leak ahead of the actual release (e.g. 0.1.8 published to Marketplace before 0.1.8 was planned). - staging.yml: derive version from branch name (release/v0.1.8 → 0.1.8) - ci.yml: use committed package.json as-is (dry-run only, no publish) - release.yml: already uses tag-direct logic (no change needed) Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The VSIX version sync logic in ci.yml and staging.yml used a PATCH+1 heuristic that auto-bumped the version when HEAD was not an exact tag match. This caused VSIX 0.1.8 to be published to the Marketplace before 0.1.8 was officially released (PyPI is still at 0.1.7).
How each workflow now derives the VSIX version
Changes