Skip to content

fix(Designer): Disable concurrency control settings for stateless workflows#9221

Merged
rllyy97 merged 1 commit into
mainfrom
rllyy97/fix-disable-runtime-settings-stateless
May 27, 2026
Merged

fix(Designer): Disable concurrency control settings for stateless workflows#9221
rllyy97 merged 1 commit into
mainfrom
rllyy97/fix-disable-runtime-settings-stateless

Conversation

@rllyy97
Copy link
Copy Markdown
Contributor

@rllyy97 rllyy97 commented May 27, 2026

Commit Type

  • fix - Bug fix

Risk Level

  • Low - Minor changes, limited scope

What & Why

LA Standard stateless workflows do not support runtime configuration settings such as concurrency control. When a user enables concurrency control on a stateless workflow, the workflow fails to save with a backend error.

This change updates isConcurrencySupported() in both designer v1 and v2 (libs/designer/ and libs/designer-v2/) to check the workflowKind and return false for stateless workflows. This hides the concurrency control toggle in the Settings panel for stateless workflows, preventing the invalid configuration from being authored in the first place.

The workflowKind parameter was already being passed to getOperationSettings() and used for other settings (e.g., count). This change follows the same established pattern to also gate concurrency support.

Fixes #9150

Impact of Change

  • Users: Users authoring stateless Standard workflows will no longer see the "Concurrency control" toggle in the General settings section of triggers/actions. This prevents save failures caused by setting an unsupported runtime configuration.
  • Developers: isConcurrencySupported() and getConcurrency() now accept an optional workflowKind parameter. Existing callers without workflowKind continue to work (parameter is optional).
  • System: No performance or architectural impact. Pure UI gating change.

Test Plan

  • Unit tests added/updated
  • E2E tests added/updated
  • Manual testing completed
  • Tested in: pnpm run build:lib succeeds for all libraries; Biome formatting and lint-staged hooks pass.

Contributors

@rllyy97

Screenshots/Videos

N/A — toggle is hidden when workflow kind is stateless.

Stateless workflows in Azure Logic Apps Standard do not support runtime
configuration settings like concurrency control. When a user sets
concurrency on a stateless workflow, the workflow fails to save.

This change updates isConcurrencySupported() in both designer v1 and v2
to check the workflowKind and return false for stateless workflows,
hiding the concurrency control toggle in the Settings panel.

Fixes #9150

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Copilot AI review requested due to automatic review settings May 27, 2026 15:54
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented May 27, 2026

🤖 AI PR Validation Report

PR Review Results

Thank you for your submission! Here's detailed feedback on your PR title and body compliance:

PR Title

  • Current: fix(Designer): Disable concurrency control settings for stateless workflows
  • Issue: No issue — this is specific and clearly describes the change.
  • Recommendation: None needed.

Commit Type

  • Properly selected (fix).
  • Only one commit type is checked, which is correct.

Risk Level

  • The selected risk label/body match: risk:low and the PR body marks Low risk.
  • Based on the diff, low is appropriate because this is a targeted UI gating change with limited scope.

What & Why

  • Current: Clear and sufficiently detailed.
  • Issue: No issue — it explains the backend failure, the stateless workflow limitation, and the fix approach.
  • Recommendation: None needed.

Impact of Change

  • The impact section is complete and aligned with the code change.
  • Recommendation:
    • Users: Good as written.
    • Developers: Good as written.
    • System: Good as written.

Test Plan

  • The PR includes manual testing, and the diff does not show unit or E2E tests.
  • This still passes because the change is primarily UI gating and the body includes a clear explanation plus build/lint verification.

Contributors

  • Contributor credit is present.
  • No changes needed.

Screenshots/Videos

  • Marked as N/A with a reasonable explanation.
  • No changes needed.

Summary Table

Section Status Recommendation
Title None
Commit Type None
Risk Level None
What & Why None
Impact of Change None
Test Plan None
Contributors None
Screenshots/Videos None

PR passes review. The advised risk level matches the submitter’s estimate and does not need to be raised.


Last updated: Wed, 27 May 2026 16:21:13 GMT

Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Disables concurrency control settings for stateless Standard Logic App workflows. Previously, enabling concurrency on a stateless workflow caused save failures; this change hides the concurrency toggle in the Settings panel by returning false from isConcurrencySupported when workflowKind === WorkflowKind.STATELESS. The fix follows the existing pattern already used for count and uploadChunk settings, which receive workflowKind through getOperationSettings.

Changes:

  • Thread workflowKind into isConcurrencySupported and getConcurrency.
  • Return false from isConcurrencySupported for stateless workflows.
  • Mirror the same change in both designer v1 and designer-v2.

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.

File Description
libs/designer/src/lib/core/actions/bjsworkflow/settings.ts Pass workflowKind through to concurrency support/value helpers and short-circuit for stateless workflows.
libs/designer-v2/src/lib/core/actions/bjsworkflow/settings.ts Same change applied to the v2 designer to keep behavior consistent.

@rllyy97 rllyy97 added the risk:low Low risk change with minimal impact label May 27, 2026
@github-actions
Copy link
Copy Markdown
Contributor

📊 Coverage Check

The following changed files need attention:

⚠️ libs/designer-v2/src/lib/core/actions/bjsworkflow/settings.ts - 17% covered (needs improvement)
⚠️ libs/designer/src/lib/core/actions/bjsworkflow/settings.ts - 17% covered (needs improvement)

Please add tests for the uncovered files before merging.

@rllyy97 rllyy97 changed the title fix: Disable concurrency control settings for stateless workflows fix(Designer): Disable concurrency control settings for stateless workflows May 27, 2026
@rllyy97 rllyy97 merged commit a5628a6 into main May 27, 2026
37 of 42 checks passed
@rllyy97 rllyy97 deleted the rllyy97/fix-disable-runtime-settings-stateless branch May 27, 2026 17:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

pr-validated risk:low Low risk change with minimal impact

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Disable runtime configuration settings for stateless workflow

3 participants