Skip to content

Fix blob SAS when using version 2026-04-06#2659

Open
Socolin wants to merge 1 commit into
Azure:mainfrom
Socolin:fix-sas-2026-04-06
Open

Fix blob SAS when using version 2026-04-06#2659
Socolin wants to merge 1 commit into
Azure:mainfrom
Socolin:fix-sas-2026-04-06

Conversation

@Socolin

@Socolin Socolin commented Jun 15, 2026

Copy link
Copy Markdown

This should fix #2649

The SDK is generating signature with new parameters

https://github.com/Azure/azure-sdk-for-net/blob/main/sdk/storage/Azure.Storage.Common/src/Sas/SasQueryParameters.cs#L103-L107

https://github.com/Azure/azure-sdk-for-net/blob/main/sdk/storage/Azure.Storage.Blobs/src/Sas/BlobSasBuilder.cs#L573-L574

# SDK
        // r\n2026-06-15T17:46:26Z\n2026-06-22T17:46:26Z\n/blob/dev/some-container-name/abc.png\n7c751eb2-acf8-4ce2-b92c-8724f0644194\nff51635d-1eb2-4fe3-8828-0c3de5b45b35\n2026-06-15T17:46:26Z\n2026-06-15T18:46:26Z\nb\n2025-11-05\n\n\n\n\n\n\n\n2026-04-06\nb\n\n\n\n\n\n\n\n\n
# Azurite
        // r\n2026-06-15T17:46:26Z\n2026-06-22T17:46:26Z\n/blob/dev/some-container-name/abc.png\n7c751eb2-acf8-4ce2-b92c-8724f0644194\nff51635d-1eb2-4fe3-8828-0c3de5b45b35\n2026-06-15T17:46:26Z\n2026-06-15T18:46:26Z\nb\n2025-11-05\n\n\n\n\n\n\n\n2026-04-06\nb\n\n\n\n\n\n\n

Copilot AI review requested due to automatic review settings June 15, 2026 18:33

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Note

Copilot was unable to run its full agentic suite in this review.

Adds support for User Delegation Key (UDK) Blob SAS signing and parsing for service version 2026-04-06, including new optional signed request headers/query parameters.

Changes:

  • Extended IBlobSASSignatureValues with signedRequestHeaders / signedRequestQueryParameters.
  • Added a new 2026-04-06 string-to-sign implementation for generateBlobSASSignatureWithUDK.
  • Updated SAS request parsing to read srh / srq query params and changelog entry.

Reviewed changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 3 comments.

File Description
src/blob/authentication/IBlobSASSignatureValues.ts Adds new SAS fields and introduces a new signing function for version 2026-04-06.
src/blob/authentication/BlobSASAuthenticator.ts Parses new query parameters (srh, srq) and wires them into the in-memory SAS values.
ChangeLog.md Documents upcoming release support for 2026-04-06 delegation SAS.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread src/blob/authentication/IBlobSASSignatureValues.ts
Comment thread src/blob/authentication/IBlobSASSignatureValues.ts
Comment thread ChangeLog.md Outdated
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

.NET SDK 12.28.0 generates SAS signatures incompatible with the ones generated in Azurite

2 participants