Fix blob SAS when using version 2026-04-06#2659
Open
Socolin wants to merge 1 commit into
Open
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Note
Copilot was unable to run its full agentic suite in this review.
Adds support for User Delegation Key (UDK) Blob SAS signing and parsing for service version 2026-04-06, including new optional signed request headers/query parameters.
Changes:
- Extended
IBlobSASSignatureValueswithsignedRequestHeaders/signedRequestQueryParameters. - Added a new
2026-04-06string-to-sign implementation forgenerateBlobSASSignatureWithUDK. - Updated SAS request parsing to read
srh/srqquery params and changelog entry.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| src/blob/authentication/IBlobSASSignatureValues.ts | Adds new SAS fields and introduces a new signing function for version 2026-04-06. |
| src/blob/authentication/BlobSASAuthenticator.ts | Parses new query parameters (srh, srq) and wires them into the in-memory SAS values. |
| ChangeLog.md | Documents upcoming release support for 2026-04-06 delegation SAS. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
12b28cc to
25ce0fd
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This should fix #2649
The SDK is generating signature with new parameters
https://github.com/Azure/azure-sdk-for-net/blob/main/sdk/storage/Azure.Storage.Common/src/Sas/SasQueryParameters.cs#L103-L107
https://github.com/Azure/azure-sdk-for-net/blob/main/sdk/storage/Azure.Storage.Blobs/src/Sas/BlobSasBuilder.cs#L573-L574