Skip to content

Withhold estimates from invalid or crossed order books - #5

Merged
Ay-obami merged 1 commit into
mainfrom
audit/orderbook-validity
Sep 29, 2026
Merged

Ay-obami merged 1 commit into
mainfrom
audit/orderbook-validity

Conversation

@Ay-obami

@Ay-obami Ay-obami commented Sep 29, 2026 •

Copy link
Copy Markdown
Owner

Scope

  • Treat missing/null/empty price fields as unpriced, filter prices outside the 0–1,000,000 micro-probability range, and withhold a marginal when the bid exceeds the ask.
  • Extract a pure book summarizer so deterministic tests cover malformed and valid one/two-sided quotes. The live SDK read still uses the same two calls.

Verification

  • Four new book tests and all 46 engine tests pass locally; git diff --check passed.
  • Both GitHub CI jobs passed: engine and site build.
  • Independent scoped review passed. SDK prices are bigint micro-units; the numeric range remains exactly representable. The tests use deterministic book fixtures; live feed freshness remains separate.

@vercel

vercel Bot commented Sep 29, 2026 •

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated
crossodds Ready Ready Preview Sep 29, 2026 7:22pm UTC

@Ay-obami
Ay-obami marked this pull request as ready for review September 29, 2026 19:23
@Ay-obami
Ay-obami merged commit c24832c into main Sep 29, 2026
6 checks passed
@Ay-obami
Ay-obami deleted the audit/orderbook-validity branch October 2, 2026 07:41

This branch was successfully deployed

1 active deployment
Preview — ea184cbf Deployed Sep 29, 2026 by vercel[bot]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant