fix(slideout): yield keyboard focus when modal is open on same screen#2902
Open
hthienloc wants to merge 1 commit into
Open
fix(slideout): yield keyboard focus when modal is open on same screen#2902hthienloc wants to merge 1 commit into
hthienloc wants to merge 1 commit into
Conversation
DankSlideout always held WlrKeyboardFocus.OnDemand regardless of modals, causing Notepad to steal focus back when Launcher was opened. ModalManager: clone currentModalsByScreen on mutation so QML bindings re-evaluate when modals open/close. DankSlideout: set keyboardFocus to None while a modal is active on the same screen, letting the modal (launcher) claim focus exclusively.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fix keyboard focus being stolen by Notepad (slideout) when Launcher is opened after it.
Root cause:
DankSlideoutalways heldWlrKeyboardFocus.OnDemandregardless of modals. When Launcher opened (also requesting keyboard focus), the Wayland compositor had no clear priority between the two surfaces, leaving focus on the slideout.Fix:
ModalManager.qml— MadecurrentModalsByScreenreactive (clone object on mutation) so QML bindings re-evaluate when modals open/closeDankSlideout.qml— Yields keyboard focus (None) when a modal is active on the same screen, allowing the Launcher (or any modal) to claim focus exclusivelyKnown limitation: When the launcher closes, keyboard focus does not automatically return to the Notepad slideout.
Type of change
Related issues
(none)
Screenshots / video
(N/A — keyboard focus behavior, no visual change)
Checklist
I18n.tr()with translator context, reusing existing terms where possiblemake fmt, added/updated tests,make testpasses, andgo mod tidyis cleanmake lint-qmlwith no new warnings