perf(lint-framework): remove unconditional lint polling#3678
Open
Elias0419 wants to merge 1 commit into
Open
Conversation
Collaborator
|
If I recall, this lint polling was necessary to keep the service worker alive. It might be more prudent to find a way to make these polls less energy intense rather than remove them altogether. |
Author
Hi - thanks for having a look. I think that the keepalive timer you are thinking of is this one: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issues
Fixes #3299
Description
This fixes the high CPU and RAM usage in the Firefox extension. It removes the unconditional polling in LintFramework and replaces it with event-driven linting.
Demo
How Has This Been Tested?
I've been running this patch on my machine for about a week now without issue. There is no more high CPU or RAM usage.
I checked it with
pnpm exec biome check --write packages/lint-framework/src/lint/LintFramework.tsAI Disclosure
If Your PR Implements or Enhances a Linter
Checklist