feat: RelativePronoun Pattern#3612
Open
hippietrail wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issues
N/A
Description
I split this out of my #3611 PR as a separate, clean, tiny PR of its own.
It makes it easy to use relative pronouns in
Exprs without adding a new annotation todictionary.dictsince there's only 5 words in the class, but helps when working on a linter when the author only thinks for "that" and "which" and maybe "who" but forgets the other two.No tests as of yet as the
Patterns I base it on didn't have any. If needed where should I put them?I thought there might be linters that could be upgraded to use this but my quick look at linters using some of these words made it seem like the current ones didn't need the full set - but I may very well have overlooked something.
How Has This Been Tested?
cargo testAI Disclosure
If Your PR Implements or Enhances a Linter
Checklist