Preserve runtime-targeted form controls#134
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
core/searchwith concrete form/input markup so search blocks expose DOM targets in serialized HTMLRoot cause
Runtime DOM selector detection was already passing IDs/classes into
runtime_dom_selectors, but the form/search conversion family still converted controls into semantic block summaries.core/searchhad no generated HTML inBlockFactory, and readable form controls such as selects/checkboxes could become paragraphs, so script-addressable control selectors disappeared from generated markup.Verification
php tests/contract/run.phpphp tests/parity/run.php --fixture=artifact-runtime-target-container-preservationcomposer testExpected impact
Targets search and form-control runtime gaps, especially selectors such as
#note-search,.search-input,.js-sort-select, and.js-filter-check. This should reduceruntime_target_gapfindings in fixtures with search controls, filters, sortable product/catalog controls, and readable forms while leaving broader JS selector mining unchanged.AI assistance