Repository navigation
feat(s3stream): support per-bucket CRT S3 clients - #3653
Merged
Merged
Conversation
Collaborator
Author
|
Validation: all 15 AwsObjectStorageTest tests, s3stream Checkstyle and SpotBugs passed. Whole-repository rat/checkstyleMain/checkstyleTest completed successfully (rat is disabled by this branch). The prescribed spotlessJavaCheck task does not exist on 1.7; Javadoc was excluded from targeted tests because of an external Oracle TLS handshake failure. Devkit produce/consume and broker-restart checks passed. Additional CRT PUT/read-back tests against Devkit MinIO passed for MD5 and CRC32 at 32 MiB minus one byte, 32 MiB, and 33 MiB with automatic multipart disabled. Devkit README has no changes in this PR. |
Gezi-lzq
approved these changes
Oct 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
Object-storage clients currently use Netty for every bucket. Operators need an opt-in CRT S3 client to tune connection health and transfer resources independently for data, WAL, and ops buckets without introducing process-wide mutable settings.
What
Add per-bucket SDK selection and tuning through camel-case BucketURI options. Netty remains the default and existing SDK API call and attempt deadlines remain available on the Netty path. Reuse the existing AWS SDK and CRT dependencies.
Each bucket uses an independent immutable configuration; CRT-only options are ignored by Netty. Disable CRT automatic multipart uploads with a fixed
Long.MAX_VALUEthreshold, preserving AutoMQ's explicit multipart uploads and request-level precomputed checksums. CRT S3 does not support the standard SDK API call/attempt deadlines.sdkImplnettynettyorcrt.connectionTimeoutMs2000numRetries2maxConcurrency-1crtTargetThroughputInGbps10crtMinimumThroughputInBps33554432crtMinimumThroughputTimeoutSeconds2crtMaxNativeMemoryLimitInBytes-1Reviewer notes
Read
AwsObjectStorage.Configuration.fromBucketURIandnewS3Clientfirst to follow parsing and SDK construction.BucketURIdeclares the shared option names.AwsObjectStorageTestcovers configuration isolation and propagation, including the fixed automatic multipart threshold.Connection health thresholds can interact with intentional throttling or host contention. Native memory budgets and throughput targets are per client and must be considered across all clients in a broker. Equal retry counts do not imply identical backoff behavior between Netty and CRT.