Skip to content

Apply the Request-Signing Layer to Mutating /v1 Swap Routes #1195

Closed

Description

@fejilaup-cloud

Labels: security, api-server
Priority: High
Estimated Time: 1.5 hours

Description:
In build_app, /v1/swap/initiate, /v1/swap/bulk/initiate, and /v1/swap/{swap_id}/cancel-expired have no .layer(signed.clone()), while accept, reveal, and cancel do. Clients can submit unsigned requests on the versioned API.

Tasks:

  • Add the signing layer to every mutating /v1 swap route
  • Add a test that an unsigned request returns 401
  • List the routes that need the layer in one place

Imported from the AtomicIp_130.md backlog (item 54).

Activity

  1. Sundriveauto commented on Oct 16, 2026

    @Sundriveauto
    Contributor

    @Sundriveauto has applied to work on this issue as part of the Stellar Wave Program's 10th wave.

    I’d like to work on this issue because enforcing request signing across all mutating swap routes is important for API security. I can update "build_app" to apply the signing layer to the initiate, bulk initiate, and cancel-expired routes, and list all protected routes in one place. I’ll also add a test confirming unsigned requests return HTTP 401 and verify that existing signed requests continue to work.

    ℹ️ Repo Maintainers: To accept this application, review their application or assign @Sundriveauto to this issue.

  2. drips-wave commented on Oct 16, 2026

    @drips-wave

    Congratulations, @Sundriveauto! 🎉 Your application was accepted by the repo's maintainers, and the issue is due on October 22, 2026.

    🧑‍💻 @Sundriveauto: Please resolve the issue such that the repo's maintainers have enough time to review your contribution before the due date. You'll earn Points for completing the issue on-time, which will make you eligible for a share of the Stellar Wave Program's reward pool.

    Warning

    When opening a PR, please link it to this issue to ensure it gets tracked accurately. Points are awarded when this issue is marked as completed by the maintainer.

    🤠 Repo maintainers: Please keep an eye on the contributor's progress and review their work before the due date. You can manage this issue, including adjusting its complexity and points, here.

    🌊 Happy Wave 🌊

  3. grantfox-oss commented on Oct 21, 2026

    @grantfox-oss

    🎉 This issue has been marked as completed on GrantFox!

    @Sundriveauto's PR #1282 was approved and merged by @fejilaup-cloud.

    🏆 @Sundriveauto: You earned 40 FoxPoints for this contribution! Your current tier: Builder (1,385 total points). Track your full progress on GrantFox.

    👏 Great work, @Sundriveauto! Keep contributing to AtomicIP.

  4. drips-wave commented on Oct 21, 2026

    @drips-wave

    This issue has been completed by @Sundriveauto as part of the Stellar Wave Program's 10th Wave 🥳

    😎 @Sundriveauto: You earned 200 Points for completing this issue! Once the Wave's rewards are finalized, you'll be eligible for a percentage of the Wave's reward pool based on the percentage of total points you've earned. Learn more here. You can also Leave a review to share your experience working on this issue.

    🧑‍💻 Repo maintainers: How'd the contributor do? Leave a review to share your experience working with them.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions