fix(local-llm): detect Apple Metal GPUs in managed device auto-pick#26
Open
Bartok9 wants to merge 1 commit into
Open
fix(local-llm): detect Apple Metal GPUs in managed device auto-pick#26Bartok9 wants to merge 1 commit into
Bartok9 wants to merge 1 commit into
Conversation
parseListDevices only matched VulkanN/CUDAN canonical rows, so common Metal list-devices formats (Metal0:, GPU 0:, ggml-metal device lines) parsed as empty and auto mode fell back to "CPU (no GPU detected)" on Apple Silicon. Normalise those forms to MetalN and treat Apple Silicon as a preferred discrete-class device for pickBestDevice. Agent-Owner: sera Signed-off-by: Bartok9 <danielrpike9@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
On Apple Silicon, managed mode often printed
auto → CPU (no GPU detected)even when Metal was available.parseListDevicesonly accepted canonicalVulkanN:/CUDAN:rows and missed common Metal list-devices formats.Fix
Metal0: …,GPU 0: …(normalised toMetalN), andggml-metal : device N = …pickBestDeviceTest plan
vitest run src/local-llm/gpu-devices.test.ts(18)atomic-agent models devices/models statusshould prefer Metal when the backend enumerates itAgent-Owner: sera