fix(browser): clear stale Chromium Singleton locks before relaunch#24
Open
Bartok9 wants to merge 1 commit into
Open
fix(browser): clear stale Chromium Singleton locks before relaunch#24Bartok9 wants to merge 1 commit into
Bartok9 wants to merge 1 commit into
Conversation
Unclean SIGINT/timeouts left SingletonLock and friends under the persistent user-data-dir, so the next browser launch failed until manual cleanup. Clear locks only when the owner PID is dead or not Chromium-family; keep locks held by a live browser. Fixes AtomicBot-ai#22 Agent-Owner: sera Signed-off-by: Bartok9 <danielrpike9@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Hard kills / SIGINT before
PlaywrightBackend.shutdown()finishes leave ChromiumSingletonLock(and friends) under the persistentuser-data-dir. The nextbrowser.*launch then fails until manual cleanup.Fix
clearStaleChromeLocks(userDataDir)with PID-aware policy:launchOwnChrome()beforedecorateChromeProfile/ spawnTest plan
vitest run src/tools/browser/clear-stale-chrome-locks.test.tsFixes #22
Agent-Owner: sera