optimizations - #6
Open
FallBackITA27 wants to merge 1 commit into
Open
Conversation
optimizations so small you might as well not merge this lol
AtishaRibeiro
requested changes
Jan 28, 2024
| var total_entries = get_entry_count(); | ||
| if (total_entries == 0) return false; | ||
| var entries = "398000" + pad(total_entries, 2); | ||
| var entries = "3980000" + total_entries.toString(16).toUpperCase(); |
Owner
There was a problem hiding this comment.
Not necessary imo, also the entire code is set to touppercase at the very end
Contributor
Author
There was a problem hiding this comment.
could just remove the method call, but nonetheless you don't need to pad it at all :P
Owner
There was a problem hiding this comment.
Sure, I just think the function call looks cleaner
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
optimizations so small you might as well not merge this lol