Bugfix - #4
Open
FallBackITA27 wants to merge 2 commits into
Open
Conversation
AtishaRibeiro
requested changes
Jan 28, 2024
AtishaRibeiro
left a comment
AtishaRibeiro
left a comment
Owner
There was a problem hiding this comment.
Maybe once you change your PR it will retrigger the checks? Not sure why they failed in the first place
| a.setAttribute("id", e.id + "autocomplete-list"); | ||
| a.setAttribute("class", "autocomplete-items"); | ||
| a.setAttribute("style",`width:${e.parentNode.offsetWidth}px`); | ||
| a.setAttribute("style",`width:${e.parentNode.offsetWidth}px;position:relative;`); // Otherwise the div will end up way lower than the actual page. --FalB |
Co-authored-by: Atisha Ribeiro <ribeiro.atisha@gmail.com>
AtishaRibeiro
requested changes
Jan 28, 2024
| a.setAttribute("id", e.id + "autocomplete-list"); | ||
| a.setAttribute("class", "autocomplete-items"); | ||
| a.setAttribute("style",`width:${e.parentNode.offsetWidth}px`); | ||
| a.setAttribute("style",`width:${e.parentNode.offsetWidth}px;position:relative;`); // Otherwise the div will end up way lower than the actual page. --FalB |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Style of the Autocomplete boxes was wrong. Also small optimization, no need to calculate stuff when you can just store the value in a variable.