Skip to content

feat(react): compose stable domain actions - #54

Merged
aryasaatvik merged 3 commits into
split/react-lifecycle-eventsfrom
split/react-domain-actions
Aug 30, 2026
Merged

feat(react): compose stable domain actions#54
aryasaatvik merged 3 commits into
split/react-lifecycle-eventsfrom
split/react-domain-actions

Conversation

@aryasaatvik

Copy link
Copy Markdown
Member

Summary

  • compose review, cleanup, and disconnect actions into the connected-provider surface
  • stabilize dialog and pending-state geometry to prevent interaction-driven layout shifts
  • move component colors, borders, focus states, and backdrops onto semantic theme tokens
  • bundle provider marks locally and avoid default third-party image requests
Before After
Separate connection-actions disclosure Connected provider card owns its actions
Action appearance coupled to package colors Host-overridable semantic tokens
Dialog state could omit open transitions Controlled open and close transitions are forwarded

Validation

  • React package typecheck
  • 57 React unit tests
  • repository lint, format, and diff checks

@github-actions

github-actions Bot commented Aug 30, 2026

Copy link
Copy Markdown
Contributor

Tegami

This repository uses Tegami to manage releases. When your changes affect published packages, add a changelog file under .tegami/ before merging.

Create a changelog → · Changelog format

Release preview

Package Bump Version
domainkit minor 0.3.10.4.0
@domainkit/react minor 0.3.10.4.0

Changelogs in this PR

Changelog Title
react-domain-actions.md Compose stable connected-domain actions

Run bun run tegami locally to create a changelog interactively.

Managed by Tegami.

@greptile-apps

greptile-apps Bot commented Aug 30, 2026

Copy link
Copy Markdown

Greptile Summary

The PR composes provisioning, cleanup, and disconnection controls into a stable connected-provider card while forwarding controlled dialog transitions and adopting semantic theme tokens.

  • Adds integrated connected-provider action menus and confirmation dialogs.
  • Preserves receipt state across provisioning and cleanup lifecycle transitions.
  • Moves component styling to host-overridable semantic tokens and local provider marks.
  • Expands lifecycle, composition, theme-contract, and browser coverage.

Confidence Score: 5/5

The PR appears safe to merge.

No blocking failure remains.

Important Files Changed

Filename Overview
packages/react/src/domain.tsx Composes connection, provisioning, cleanup, disconnection, records, and verification into the revised domain lifecycle surface.
packages/react/src/connection.tsx Adds integrated disconnection state and dialog behavior while stabilizing pending connection controls.
packages/react/src/cleanup.tsx Converts cleanup into a controlled alert-dialog workflow with retry, completion callbacks, and transition forwarding.
packages/react/src/provisioning.tsx Updates provisioning interaction state and composition for the connected-provider surface.
packages/react/src/styles.css Revises connected-card, action-menu, dialog, and pending-state styling around semantic theme tokens.
packages/react/src/theme.ts Extends the public semantic theme-token contract used by the revised components.
packages/react/src/provider.tsx Replaces default remote provider artwork with locally bundled provider marks.
packages/react/tests/domain-lifecycle.test.tsx Expands coverage for composed provisioning, cleanup, receipt, and disconnection lifecycle behavior.

Flowchart

%%{init: {'theme': 'neutral'}}%%
flowchart TD
  Domain[Domain Flow] --> Inspect[Inspect connection]
  Inspect -->|Available| Available[Available provider card]
  Inspect -->|Connected| Connected[Connected provider card]
  Connected --> Provision[Provision DNS records]
  Connected --> Actions[Provider actions menu]
  Actions --> Cleanup[Review and clean records]
  Actions --> Disconnect[Confirm domain disconnection]
  Domain --> Records[Records table]
  Domain --> Verify[Verification status]
Loading

Reviews (5): Last reviewed commit: "chore(release): note React domain action..." | Re-trigger Greptile

@aryasaatvik
aryasaatvik force-pushed the split/react-domain-actions branch 3 times, most recently from d90bf9b to 9f52c2a Compare August 30, 2026 23:06
@aryasaatvik
aryasaatvik force-pushed the split/react-domain-actions branch from 9f52c2a to 37d21ae Compare August 30, 2026 23:08
@aryasaatvik
aryasaatvik merged commit 1c23127 into main Aug 30, 2026
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant