Boundary checks still happen if depth = 1 - #71
Closed
riccardi48 wants to merge 1 commit into
Closed
riccardi48 wants to merge 1 commit into
riccardi48 wants to merge 1 commit into
Conversation
Owner
|
Yeah I think specialcasing a 2D sim might be best for now instead of dealing with generalizing 2D/3D interactions and just making constant coords checks how its handled. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stack two chunks on top of each other with depth 1 and put gas into one. The other chunk will not receive any gas.
There are a number of problems causing this but mainly is that it assumes that a depth of one means that the chunk is 2d. For intra chunk stuff this is fine as it might as well be, however, for inter chunk stuff this brakes it.
I don't love the solution here of just checking all of it. It will lead to a lot of boundary events for voxels not on the boundary. A better solution is probably to define chunks as 2d in a better way instead of relying on the chunk depth.
If a better solution is found feel free to close this PR as it is closer to a bug report then PR but it is good to show the code which is causing the issue.